Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Allow environment to override http/https for apis #45

Merged
c-w merged 1 commit into from
Jul 5, 2017
Merged

Allow environment to override http/https for apis #45

c-w merged 1 commit into from
Jul 5, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 5, 2017

As per standup today: environment variables should be able to override whether we talk to services via http or https.

@c-w c-w requested a review from kevinhartman July 5, 2017 17:07
@c-w c-w added the in progress label Jul 5, 2017
kevinhartman
kevinhartman approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 61516de into master Jul 5, 2017
@c-w c-w deleted the protocol-from-env branch July 5, 2017 17:24
@c-w c-w removed the in progress label Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kevinhartman kevinhartman kevinhartman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-w @kevinhartman