Skip to content
This repository has been archived by the owner. It is now read-only.

Fix a few IDEA inspections #93

merged 1 commit into from Aug 16, 2017


None yet
2 participants
Copy link

commented Aug 16, 2017

No functional change.

@c-w c-w requested a review from kevinhartman Aug 16, 2017

@c-w c-w added the in progress label Aug 16, 2017

@@ -21,8 +21,8 @@ class TransformContextProvider(configManager: ConfigurationManager, featureServi

// Do not serialize these values. The transformContext would otherwise contain stale Broadcast
// instances, so we rebuild it on recovery from checkpoint.
@volatile @transient private var transformContext: TransformContext = null
@volatile @transient private var queueClient: QueueClient = null
@volatile @transient private var transformContext: TransformContext = _

This comment has been minimized.

Copy link

kevinhartman Aug 16, 2017


IMO, null is more explicit, since we're expecting this to be exactly null (i.e. line 48), though I understand this likely fixes a style warning.

@c-w c-w merged commit 5c3296f into master Aug 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@c-w c-w deleted the fix-inspections branch Aug 16, 2017

@c-w c-w removed the in progress label Aug 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.