Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Ensure that eventid is unique #94

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Ensure that eventid is unique #94

merged 1 commit into from
Aug 16, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Aug 16, 2017

As per conversation around CatalystCode/project-fortis-pipeline#111

@c-w c-w requested a review from erikschlegel August 16, 2017 15:00
jcjimenez
jcjimenez approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erikschlegel
erikschlegel approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@erikschlegel erikschlegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remember to update the cassandra ddls and the eventid datatype should remain as text

@c-w
Copy link
Contributor Author

c-w commented Aug 16, 2017

@erikschlegel Yes, already posted the PR for the DDL update CatalystCode/project-fortis-pipeline#111

@c-w c-w merged commit 35d8a48 into master Aug 16, 2017
@c-w c-w deleted the eventid branch August 16, 2017 16:01
@c-w c-w removed the in progress label Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcjimenez jcjimenez jcjimenez approved these changes

@kevinhartman kevinhartman kevinhartman approved these changes

@erikschlegel erikschlegel erikschlegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-w @jcjimenez @kevinhartman @erikschlegel