Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Cassandra error details #22

Merged
merged 1 commit into from Feb 14, 2018
Merged

Hide Cassandra error details #22

merged 1 commit into from Feb 14, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 13, 2018

According to @anthturner it's not good practice to expose detailed error messages from the database to clients as this makes it easier for an attacker to figure out potential attack vectors.

This pull request masks the Cassandra error messages in favor of more generic ones that don't risk leaking sensitive information.

See CatalystCode/project-fortis-pipeline#222

@c-w c-w requested review from anthturner and Smarker Feb 13, 2018
Copy link
Member

@anthturner anthturner left a comment

LGTM

@c-w c-w merged commit 613aab8 into master Feb 14, 2018
2 checks passed
@c-w c-w deleted the hide-errors branch Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants