Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hard-code location of cognitive services #25

Merged
merged 1 commit into from Feb 20, 2018
Merged

Don't hard-code location of cognitive services #25

merged 1 commit into from Feb 20, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 20, 2018

Previously we were assuming that the cognitive services called in the
spark jobs are always deployed in WESTUS which leads to failed calls
when the resources are set up somewhere else, e.g. in EASTUS. This
change passes the resource group location in which the cognitive
services were created through to spark so that we can format the
appropriate base URL for the services.

As a tangential change, this commit also removes the ability to provide
cognitive services tokens at deploy time. We already have the ability to
set up new cognitive services accounts during the fortis-deploy.sh
script so we might as well leverage that to ensure that the cognitive
services tokens and deployment locations don't risk getting out of sync
which will lead to hard to debug errors for the user. This changes also
has some related benefits, e.g. making billing more straight forward
since all Fortis resources will be located in the same resource group by
construction.

Previously we were assuming that the cognitive services called in the
spark jobs are always deployed in WESTUS which leads to failed calls
when the resources are set up somewhere else, e.g. in EASTUS. This
change passes the resource group location in which the cognitive
services were created through to spark so that we can format the
appropriate base URL for the services.

As a tangential change, this commit also removes the ability to provide
cognitive services tokens at deploy time. We already have the ability to
set up new cognitive services accounts during the fortis-deploy.sh
script so we might as well leverage that to ensure that the cognitive
services tokens and deployment locations don't risk getting out of sync
which will lead to hard to debug errors for the user. This changes also
has some related benefits, e.g. making billing more straight forward
since all Fortis resources will be located in the same resource group by
construction.
@c-w c-w requested a review from kevinhartman Feb 20, 2018
@c-w
Copy link
Contributor Author

@c-w c-w commented Feb 20, 2018

image

@c-w c-w merged commit 09da523 into master Feb 20, 2018
2 checks passed
@c-w c-w deleted the cognitive-spark branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants