From 13004e9a329fcfb56d6ae900618a8aa7f08e2c8a Mon Sep 17 00:00:00 2001
From: Dennis Seah <dennis.seah@gmail.com>
Date: Fri, 14 Feb 2020 07:37:48 -0800
Subject: [PATCH] making sure that promises complete

---
 src/lib/azure/deploymenttable.ts | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/lib/azure/deploymenttable.ts b/src/lib/azure/deploymenttable.ts
index f2110bd64..5911dcde6 100644
--- a/src/lib/azure/deploymenttable.ts
+++ b/src/lib/azure/deploymenttable.ts
@@ -33,7 +33,7 @@ export const addSrcToACRPipeline = (
   entry.service = serviceName;
   entry.commitId = commitId;
   entry.PartitionKey = tableInfo.partitionKey;
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     insertToTable(tableInfo, entry)
       .then(() => {
         logger.info("Added first pipeline details to the database");
@@ -41,6 +41,7 @@ export const addSrcToACRPipeline = (
       })
       .catch(err => {
         logger.error(err);
+        reject(err);
       });
   });
 };
@@ -61,7 +62,7 @@ export const updateACRToHLDPipeline = (
   env: string,
   pr?: string
 ): Promise<any> => {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     findMatchingDeployments(tableInfo, "imageTag", imageTag).then(entries => {
       let entryToInsert: any;
       for (const entry of entries) {
@@ -86,6 +87,7 @@ export const updateACRToHLDPipeline = (
             })
             .catch(err => {
               logger.error(err);
+              reject(err);
             });
           return;
         }
@@ -109,6 +111,7 @@ export const updateACRToHLDPipeline = (
           })
           .catch(err => {
             logger.error(err);
+            reject(err);
           });
         return;
       }
@@ -132,6 +135,7 @@ export const updateACRToHLDPipeline = (
         })
         .catch(err => {
           logger.error(err);
+          reject(err);
         });
       return;
     });
@@ -197,7 +201,7 @@ export const updateHLDtoManifestHelper = (
   manifestCommitId?: string,
   pr?: string
 ): Promise<any> => {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     let entryToInsert: any;
     for (const entry of entries) {
       entryToInsert = entry;
@@ -220,6 +224,7 @@ export const updateHLDtoManifestHelper = (
           })
           .catch(err => {
             logger.error(err);
+            reject(err);
           });
         return;
       }
@@ -243,6 +248,7 @@ export const updateHLDtoManifestHelper = (
         })
         .catch(err => {
           logger.error(err);
+          reject(err);
         });
       return;
     }
@@ -267,6 +273,7 @@ export const updateHLDtoManifestHelper = (
       })
       .catch(err => {
         logger.error(err);
+        reject(err);
       });
     return;
   });
@@ -283,7 +290,7 @@ export const updateManifestCommitId = (
   pipelineId: string,
   manifestCommitId: string
 ): Promise<any> => {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     findMatchingDeployments(tableInfo, "p3", pipelineId).then(entries => {
       // Ideally there should only be one entry for every pipeline id
       if (entries.length > 0) {
@@ -298,6 +305,7 @@ export const updateManifestCommitId = (
           })
           .catch(err => {
             logger.error(err);
+            reject(err);
           });
       } else {
         logger.error(