New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the private set; in the documentation #1078

Closed
advapiIT opened this Issue Jul 28, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@advapiIT

advapiIT commented Jul 28, 2017

Since with C#6 the private set; became useless, and Catel is build upon latest C# version I suggest that this setter can be removed from doc and from code as well

For example in this link

@GeertvanHorrik

This comment has been minimized.

Show comment
Hide comment
@GeertvanHorrik

GeertvanHorrik Jul 28, 2017

Member

Thanks for the ticket. Since I agree that it's now possible to write properties like this, I don't see any added value in pro-actively removing the private setters (it doesn't actually change behavior). But we can modify the classes once we hit them.

Member

GeertvanHorrik commented Jul 28, 2017

Thanks for the ticket. Since I agree that it's now possible to write properties like this, I don't see any added value in pro-actively removing the private setters (it doesn't actually change behavior). But we can modify the classes once we hit them.

@GeertvanHorrik

This comment has been minimized.

Show comment
Hide comment
@GeertvanHorrik

GeertvanHorrik Jan 25, 2018

Member

Closing as we think this is not very important for the docs.

Member

GeertvanHorrik commented Jan 25, 2018

Closing as we think this is not very important for the docs.

@GeertvanHorrik GeertvanHorrik removed this from the Up for grabs milestone Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment