New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code snippets are missing some parts #1132

Closed
Loreno10 opened this Issue Oct 30, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Loreno10
Contributor

Loreno10 commented Oct 30, 2017

I'm just learning Catel and already I noticed that some snippets are wrong. I did a Pull Request for 'model' snippet, because this one was clearly wrong - i was quite surprised since this is probably the most fundamental snippet.
Since I'm very new to all this I'm adding this Issue, so that some more advanced user could check the snippets. I think that 'vm' is also wrong, but, as I stated, I'm new to everything MVVM, so I didn't really start too look closely into it.

@GeertvanHorrik

This comment has been minimized.

Show comment
Hide comment
@GeertvanHorrik

GeertvanHorrik Oct 30, 2017

Member

Thanks for reporting. We'll look into the PR soon.

Member

GeertvanHorrik commented Oct 30, 2017

Thanks for reporting. We'll look into the PR soon.

@GeertvanHorrik

This comment has been minimized.

Show comment
Hide comment
@GeertvanHorrik

GeertvanHorrik Oct 30, 2017

Member

Just merged, thanks for fixing. What do you think is wrong about the VM snippet?

Member

GeertvanHorrik commented Oct 30, 2017

Just merged, thanks for fixing. What do you think is wrong about the VM snippet?

@GeertvanHorrik

This comment has been minimized.

Show comment
Hide comment
@GeertvanHorrik

GeertvanHorrik Mar 21, 2018

Member

Closing this ticket. If you have any questions, feel free to re-open.

Member

GeertvanHorrik commented Mar 21, 2018

Closing this ticket. If you have any questions, feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment