Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservableDictionary Support #1421

Closed
ghost opened this issue Sep 10, 2019 · 5 comments
Closed

ObservableDictionary Support #1421

ghost opened this issue Sep 10, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@ghost
Copy link

@ghost ghost commented Sep 10, 2019

IF YOU DON'T ANSWER THIS TEMPLATE - THE BOT WILL AUTOMATICALLY CLOSE YOUR ISSUE!

Summary

Introduces a new type of Dictionary that implements INotifyCollectionChanged and INotifyPropertyChanged.

API Changes

  • Implement ObservableCollection in Catel.MVVM
  • Create Approval Tests for ObservableCollection
  • Create Unit Tests for ObservableCollection

Intended Use Case

Useful for scenarios such as ComboBox controls that utilize Dictionaries as an item source but require the flexibility of adding, updating and removing items based on business logic within a ViewModel or Service.

As a final note, we actually already have this implementation completed as we utilize it for our in-house applications that are built on-top of Catel. The purpose is to share the feature to other users of the framework who may need it.

@GeertvanHorrik
Copy link
Member

@GeertvanHorrik GeertvanHorrik commented Sep 10, 2019

Nice, would love to see this in the framework.

Loading

@GeertvanHorrik GeertvanHorrik added this to the 5.12.0 milestone Sep 10, 2019
@GeertvanHorrik GeertvanHorrik self-assigned this Sep 10, 2019
@ghost
Copy link
Author

@ghost ghost commented Sep 10, 2019

Great, we'll allocate some time to get this into a PR.

Loading

@ghost
Copy link
Author

@ghost ghost commented Sep 12, 2019

Just an additional note there will also be the addition of ToObservableDictionary extension methods to allow short-hand instantiation. I failed to mention that in the beginning.

Loading

@GeertvanHorrik
Copy link
Member

@GeertvanHorrik GeertvanHorrik commented Sep 12, 2019

Great, I'd love to see that.

Loading

@lock
Copy link

@lock lock bot commented Nov 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant