New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATROID-181 Fix issue where visual placement jumps after panning #3150
Conversation
catroid/src/main/java/org/catrobat/catroid/stage/VisualPlacementActivity.java
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/stage/VisualPlacementActivity.java
Outdated
Show resolved
Hide resolved
catroid/src/main/java/org/catrobat/catroid/stage/VisualPlacementActivity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take the time in account. E.g. SystemClock.elapsedRealTime()
very helpful, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the onTouch behavior into a separate, unit testable class as discussed personally
52e23ec
to
a9e32c3
Compare
done, but without test (sorry), because I couldn't understand the way of Mockito |
9af11b0
to
1ad3f0d
Compare
41b701d
to
187c760
Compare
catroid/src/main/java/org/catrobat/catroid/visualplacement/VisualPlacementTouchListener.java
Outdated
Show resolved
Hide resolved
…nger position after careful panning to another position
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed yesterday face to face.
…nger position after careful panning to another position
IMO this fixes the issue described in the ticket. I talked to @ndrnour and I think if there is anything else to do we should do it as another separate ticket. |
I implemented what I could and saw right. I missed one part regarding ignoring the last 100 ms. |
Thanks a lot, and I fully understand ;-) there are many more things to add to the visual placement, and yes, someone else can take over --- sorry for being so nitpicking!!! |
Visual placement sometimes incorrectly jumps object to finger position after careful panning to another position.