New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file names including spaces are not correctly saved in the project file #167

Closed
ymargarin opened this Issue Dec 2, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ymargarin
Copy link

ymargarin commented Dec 2, 2015

I just edited the xml file and replaced the spaces in the file names by %20 and opened again the project file. It worked.
Please fix, thanks

@jcoffland

This comment has been minimized.

Copy link
Member

jcoffland commented Dec 15, 2015

I thought I fixed this. It was issue #50. I'll look in to it. Thanks for the report.

@ymargarin

This comment has been minimized.

Copy link

ymargarin commented Dec 15, 2015

Hi,
Thanks for the feedback.

To be more factual, since I was able to load the files after substituting the space characters by %20, I thought that the issue was related to spaces. I saw the issue #50 and thought that the fix wasn't complete, hence my message.

After a more thorough review, I'm realizing that the issue might be linked to both the presence of " ! " and the space characters. My files have this structure:
!Motor Command Board_ver 2.2.drl.ngc ; !Motor Command Board_ver 2.2-B_Cu.ngc ; ...
and the complete path is:
"D:\My_Vault!CAD\Kicad\My_Projects\Remote receiver for shade motor!Motor Interface Unit!Motor Command Board\Manufacturing\NEW_ Ver 2.2!Motor Command Board_ver 2.2-B_Cu.ngc"
the " ! " is here to provide a hierarchy in explorer and I'm extensively using it.

The result after "save project as" and "load project" is:
2015-12-15_153509

I have a similar structure in another directory but the exclamation mark is in he path instead of being in the filename. Here's the complete path followed by a picture of the resulting list:
"D:\My_Vault!CAD\Kicad\My_Projects\Remote receiver for shade motor!Motor Interface Unit Design-2\Manufacturing\Timer board-Edge_Cuts.gbr.ngc".
2015-12-15_154616.

I'm aware of some character avoidance within the CAD file filenames but until now, everything worked fine with kicad, mach3, flatcam, wings and a bunch of other programs.

Sorry for the misleading, I do hope that this clarification will help.
looking forward to ...
best regards

@jcoffland jcoffland added this to the 1.1.0 milestone Sep 24, 2016

jcoffland added a commit that referenced this issue Sep 25, 2016

@jcoffland jcoffland added the bug label Sep 25, 2016

@jcoffland jcoffland closed this Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment