Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate documentation of Haralick texture features vs code #2362

Closed
AnneCarpenter opened this issue Sep 23, 2016 · 3 comments
Closed

Investigate documentation of Haralick texture features vs code #2362

AnneCarpenter opened this issue Sep 23, 2016 · 3 comments

Comments

@AnneCarpenter
Copy link
Member

The help for MeasureTexture says this:

For example, if you choose a scale of 2, each pixel in the image (excluding some border pixels) will be compared against the one that is two pixels to the right.

but we think this ought to state "two pixels in every direction" for a total of 16 (the ring of pixels two away from any given pixel).

Similarly, the help states this:

MeasureTexture quantizes the image into eight intensity levels.

and we are surprised it's only 8; we would have imagined it being quite a few more to be sensitive. We also wonder how this quantization is done: is it scaled to the maximum intensity value within each image (we hope not), which would make it quite relative from one image to the next.

@braymp
Copy link
Contributor

braymp commented Sep 23, 2016

Re: direction - I thought that the "Angle to measure" setting below specifies the direction. But you're right: the module could be updated to reflect that this setting was added after the help was written.

Re: quantization - Yep, it's 8: https://github.com/CellProfiler/centrosome/blob/master/centrosome/haralick.py#L108

@braymp
Copy link
Contributor

braymp commented Sep 23, 2016

I wold actually be much more impressed if are able to produce more definitive descriptions of each of the features. I get this question a lot.

I remember trying to flesh the docs out in the past (you can see that some feature descriptions have more than others), but in general, my google-fu skills have failed me in this area.

@bethac07
Copy link
Member

bethac07 commented Dec 5, 2017

12/2017 update- I think the "2 pixels to the right" language still needs to be addressed; my reading of the mahotas Haralick impelmentation makes me think the 8 level thing is almost certainly no longer true but would appreciate someone else's backup on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants