Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module names #2906

Merged
merged 9 commits into from Aug 30, 2017

Conversation

Projects
None yet
1 participant
@mcquin
Copy link
Contributor

commented Aug 30, 2017

  • ApplyThreshold -> Threshold
  • CalculateImageOverlap -> MeasureImageOverlap
  • NoiseReduction -> ReduceNoise
  • CropObjects -> SaveCroppedObjects
  • MeasureCorrelation -> MeasureColocalization
  • Remove objects -> RemoveObjectsBySize
  • MeasureNeuron -> MeasureObjectSkeleton
  • ReassignObjectNumbers -> SplitOrMergeObjects (alias only)

@mcquin mcquin changed the title [WIP] Rename module names Rename module names Aug 30, 2017

@mcquin
Copy link
Contributor Author

left a comment

Few small changes, everything else looks great!

.gitignore Outdated
src/
!/tests/modules/test_correctilluminationcalculate.py

This comment has been minimized.

Copy link
@mcquin

mcquin Aug 30, 2017

Author Contributor

This line should be removed.

'trackobjects': 'TrackObjects',
'tile': 'Tile',
'tophattransform': 'TopHatTransform',
'calculateimageoverlap': 'CalculateImageOverlap',
'calculateimageoverlap': 'MeasureImageOverlap',

This comment has been minimized.

Copy link
@mcquin

mcquin Aug 30, 2017

Author Contributor

This line is a duplicate, it can be removed.

This comment has been minimized.

Copy link
@mcquin

mcquin Aug 30, 2017

Author Contributor

Let's double check that "calculateimageoverlap" is not defined in builtin_modules, too.

mcquin

@mcquin mcquin merged commit e9170b7 into master Aug 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mcquin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2017

Nice work, @DuaaAli !! 🎉

@0x00b1 0x00b1 deleted the issues/2870 branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.