Initial merge from herlo/paas-sig-ci #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create the common role move the setup vars into common vars remove the common call in the setup.yml add meta dir with dependencies main.yml
Update Atomic Openshift Installer config template
It will be a dependency in the oabuild and rfs roles at a minimum
remove nginx include, make it a dependency remove build of golang libs as the builddeps does this properly
remove nginx include, make it a dependency
allow common and nginx roles to become meta deps rework handlers to be part of meta deps where possible
enable openshift repo (testing), allows only ansible and deps if building from source ssh keys distributed to all hosts in the cluster
added 5 commits
August 26, 2016 13:21
Two plugins that needed to make this more clean. PostBuildScript Plugin - https://wiki.jenkins-ci.org/display/JENKINS/PostBuildScript+Plugin NodeLabel Parameter Plugin - https://wiki.jenkins-ci.org/display/JENKINS/NodeLabel+Parameter+Plugin
| @@ -0,0 +1,91 @@ | |||
| - defaults: | |||
There was a problem hiding this comment.
Do we want to remove this file since it is all commented out anyway?
There was a problem hiding this comment.
I don't see any commented lines in this file.
|
In general LGTM. I see you swapped the node role for setup maybe it should really be prep since that is what we are doing but I am fine with setup as well. |
| --- | ||
| - hosts: all | ||
| sudo: '{{ sudo | default("no") }}' | ||
| user: '{{ user | default("root") }}' |
|
One remote_user missed otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the work to build up and test origin. Currently, the following jenkins job exists:
Openshift from source