Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing weekly scan to run in proper controlled manner. #615
dharmit left a comment
@mohammedzee1000 with potential future use cases, we can't do things right now. If in future we do end up in a scenario you think we would end up in, we can change things like this then since it's just about doing
Sep 11, 2018
navidshaikh left a comment
Its been 3 iterations to ask for same review feedback and fixes, specifically for English statements in the PR.
I'd still want to request changes, however since we need to move faster for prod deployment and testing, I won't block this PR to go in.
We have reviews from other PRs about streamlining the parameter definitions in templates, I am hoping to have the fixes in that work.