Added job config for unit tests and functional tests with service job #624

bamachrn · 2018-09-10T09:27:00Z

This PR contains job configs for

service job: This configures and updates all the CI job for container-pipeline-service
container-index-ci: This job runs from container-pipeline-master and checks sanity for container-index
container-pipeline-service-ci-pr-openshift: This runs functional tests for service from openshift branch of the repo.
- This runs in each PR raised to the openshift branch of container-pipeline-service repo
- #dotests manually triggers it
container-pipeline-service-ci-pr-unittests: This runs unit tests for service from the openshift branch of the repo.
- This runs in each PR raised to the openshift branch of container-pipeline-service repo
- #dotests-unittests manually triggers it

All the test jobs updates their status with a different status-context which shows up in github as multiple checks

bamachrn · 2018-09-10T09:29:58Z

#dotests

bamachrn · 2018-09-10T09:30:56Z

#dotests-unittests

navidshaikh · 2018-09-12T08:04:26Z

ci/job.yml

+            sh ./cccp_ci_container_index.sh
+
+- job:
+    name: 'centos-container-pipeline-service-ci-pr-openshift'


We don't need quotes here. We didn't use quotes in other job names.

Adding quotes is always better in jjb template name to avoid surprises. Added to all the jobs now.

navidshaikh · 2018-09-12T08:07:01Z

ci/job.yml

+              - navidshaikh
+            cron: '* * * * *'
+            github-hooks: false
+            permit-all: true


add

trigger-phrase: '#dotests'

also add other properties here well like in ci-functional ? Like messages when its started, succeed, failed, error etc?

@bamachrn : We need either #dotests or ok to test string right for triggering the CI via comment?

by default it is ok to test. and in this pr we are not changing anything from index CI

I pointed out to streamline the trigger CI string in comment in both repositories.

Added #dotests for index ci

navidshaikh · 2018-09-12T08:08:26Z

ci/job.yml

+              cd ci
+              sh trigger_ci.sh ${GIT_URL} ${GIT_BRANCH} ${sha1}
+            else
+              echo "It is not on openshit branch"


*The PR's target branch is not openshift.

navidshaikh · 2018-09-12T08:08:44Z

ci/job.yml

+                - navidshaikh
+                - mohammedzee1000
+                - cdrage
+            trigger-phrase: '#dotests-unittests'


navidshaikh · 2018-09-12T08:08:52Z

ci/job.yml

+            started-status: "centos-ci functional tests started"
+            success-status: "centos-ci functional tests succeeded"
+            failure-status: "centos-ci functional tests failed"
+            error-status: "centos-ci functional tests errored"


navidshaikh · 2018-09-12T08:09:05Z

ci/job.yml

+            started-status: "centos-ci unit tests started"
+            success-status: "centos-ci unit tests succeeded"
+            failure-status: "centos-ci unit tests failed"
+            error-status: "centos-ci unit tests errored"


navidshaikh · 2018-09-12T08:09:33Z

ci/job.yml

+              git rebase origin/${ghprbTargetBranch}
+              bash ci/ccp_ci_unittests.sh
+            else
+              echo "It is not on openshit branch"


*The PR's target branch is not openshift.

navidshaikh · 2018-09-19T04:51:15Z

@bamachrn: can you take a look at review comments and update the PR?

bamachrn · 2018-09-19T07:00:13Z

#dotests-unittests

dharmit

Looks good overall. Requested a few changes in terms of doc.
Can we use jjb templates for repeating code? Not right away but maybe after the prod deployment.

ci/jjb_service_job.yml

dharmit · 2018-09-19T08:03:42Z

ci/jjb_service_job.yml

+                - openshift
+    builders:
+        - shell: |
+            jenkins-jobs --ignore-cache --conf ~/jenkins_jobs.ini update ci/job.yml


There's no need to use absolute path here, right?

I would say we are safer using absolute paths than relative paths, unless they are going to change constantly

here for the jenkins_jobs.ini we are note sure about the absolute path all the time, but we want to use jenkins_job.ini form users home directory. This runs from jenkins workspace, and key is from home directory. So better to not introduce complexity, when jenkins can handle this itself.

dharmit · 2018-09-19T08:10:28Z

ci/job.yml

@@ -0,0 +1,168 @@
+- job:
+    name: 'centos-container-pipeline-service-container-index'
+    description: |


Similar request for description as for the service-job.

dharmit · 2018-09-19T08:12:04Z

ci/job.yml

+            started-status: "centos-ci container-index ci  tests started"
+            success-status: "centos-ci container-index ci  tests succeeded"
+            failure-status: "centos-ci container-index ci  tests failed"
+            error-status: "centos-ci container-index ci  tests errored"


Is it required to have multiple spaces for above four statuses?

this is kind of typo while copy paste, fixing this.

dharmit · 2018-09-19T08:17:26Z

ci/job.yml

+    builders:
+        - shell: |
+            git rebase origin/${ghprbTargetBranch}
+            curl https://raw.githubusercontent.com/CentOS/container-pipeline-service/master/ci/cccp_ci_container_index.sh > cccp_ci_container_index.sh


Out of curiosity, how do we handle a situation where the script being downloaded here itself needs to be changed?

Yes, in this situation it will cause an issue for testing before merge. Although this script should not need to change very often, it is a possibility.

This is container-index CI, and the script itself downloads/clones all the required code base. So, whenever there is a change in the script, it will be tracked with the container-pipeline ci, not this one. @mohammedzee1000 I believe you can give us better explanation, if required on this.

dharmit · 2018-09-19T08:19:30Z

ci/job.yml

@@ -0,0 +1,168 @@
+- job:
+    name: 'centos-container-pipeline-service-container-index'


Is it just me or it's actually confusing that the name has both "Container Pipeline Service" and "Container Index"? Which one exactly does it do CI for?

I think we could prepend our CI jobs with ccp if that's the reason why we have mentioned "centos-container-pipeline-service" in the name.

updated to centos-container-index-ci.

dharmit · 2018-09-19T08:22:34Z

ci/job.yml

+              cd ci
+              sh trigger_ci.sh ${GIT_URL} ${GIT_BRANCH} ${sha1}
+            else
+              echo "PRs target branch is not openshift"


s/PRs/PR's/

navidshaikh

LGTM

bamachrn changed the title ~~Added job config for unit tests ans functional tests with service job~~ [WIP]Added job config for unit tests ans functional tests with service job Sep 10, 2018

bamachrn closed this Sep 10, 2018

bamachrn reopened this Sep 10, 2018

bamachrn changed the title ~~[WIP]Added job config for unit tests ans functional tests with service job~~ Added job config for unit tests ans functional tests with service job Sep 10, 2018

bamachrn added the prod label Sep 11, 2018

bamachrn changed the title ~~Added job config for unit tests ans functional tests with service job~~ Added job config for unit tests and functional tests with service job Sep 12, 2018

bamachrn assigned navidshaikh Sep 12, 2018

navidshaikh reviewed Sep 12, 2018

View reviewed changes

bamachrn added 3 commits September 19, 2018 12:02

Added job config for unit tests ans functional tests with service job

d4c4963

Trigger build automatically when PR raised

ad95572

Updated CI job to get triggered using #dotests

82fad91

bamachrn force-pushed the openshift branch from f3b6aff to 82fad91 Compare September 19, 2018 06:55

dharmit requested changes Sep 19, 2018

View reviewed changes

Added description to the jobs

649cc89

bamachrn force-pushed the openshift branch from f041125 to 649cc89 Compare September 19, 2018 11:22

dharmit approved these changes Sep 19, 2018

View reviewed changes

navidshaikh approved these changes Sep 19, 2018

View reviewed changes

navidshaikh merged commit c6083f6 into CentOS:openshift Sep 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added job config for unit tests and functional tests with service job #624

Added job config for unit tests and functional tests with service job #624

bamachrn commented Sep 10, 2018 •

edited

bamachrn commented Sep 10, 2018

bamachrn commented Sep 10, 2018

navidshaikh Sep 12, 2018

bamachrn Sep 19, 2018

navidshaikh Sep 12, 2018

navidshaikh Sep 12, 2018

bamachrn Sep 17, 2018 •

edited

navidshaikh Sep 17, 2018

bamachrn Sep 19, 2018

navidshaikh Sep 12, 2018

navidshaikh Sep 12, 2018

navidshaikh Sep 12, 2018

navidshaikh Sep 12, 2018

navidshaikh Sep 12, 2018

navidshaikh commented Sep 19, 2018

bamachrn commented Sep 19, 2018

dharmit left a comment

dharmit Sep 19, 2018

mohammedzee1000 Sep 19, 2018

bamachrn Sep 19, 2018

dharmit Sep 19, 2018

dharmit Sep 19, 2018

bamachrn Sep 19, 2018 •

edited

dharmit Sep 19, 2018

mohammedzee1000 Sep 19, 2018

bamachrn Sep 19, 2018

dharmit Sep 19, 2018

dharmit Sep 19, 2018

bamachrn Sep 19, 2018

dharmit Sep 19, 2018

navidshaikh left a comment

		@@ -0,0 +1,168 @@
		- job:
		name: 'centos-container-pipeline-service-container-index'

Added job config for unit tests and functional tests with service job #624

Added job config for unit tests and functional tests with service job #624

Conversation

bamachrn commented Sep 10, 2018 • edited

bamachrn commented Sep 10, 2018

bamachrn commented Sep 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bamachrn Sep 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

navidshaikh commented Sep 19, 2018

bamachrn commented Sep 19, 2018

dharmit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bamachrn Sep 19, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

navidshaikh left a comment

Choose a reason for hiding this comment

bamachrn commented Sep 10, 2018 •

edited

bamachrn Sep 17, 2018 •

edited

bamachrn Sep 19, 2018 •

edited