From 9d4415df790c552256a6fd26148800596206989f Mon Sep 17 00:00:00 2001 From: Nazar Semets Date: Fri, 9 May 2025 10:27:51 +0300 Subject: [PATCH] fix(bug): icon and nav menu --- src/app/core/components/header/header.component.ts | 4 ++-- src/app/core/components/nav-menu/nav-menu.component.html | 1 + src/app/core/components/nav-menu/nav-menu.component.ts | 8 +++++++- src/app/core/components/topnav/topnav.component.html | 2 +- .../shared/components/resources/resources.component.html | 4 ++-- src/assets/icons/source/filter.svg | 7 +++---- 6 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/app/core/components/header/header.component.ts b/src/app/core/components/header/header.component.ts index d4d5bd91d..b283b1d10 100644 --- a/src/app/core/components/header/header.component.ts +++ b/src/app/core/components/header/header.component.ts @@ -4,7 +4,7 @@ import { computed, inject, } from '@angular/core'; -import { Router, RouterLink } from '@angular/router'; +import { Router } from '@angular/router'; import { toSignal } from '@angular/core/rxjs-interop'; import { map } from 'rxjs'; import { BreadcrumbComponent } from '@core/components/breadcrumb/breadcrumb.component'; @@ -16,7 +16,7 @@ import { UserSelectors } from '@core/store/user/user.selectors'; @Component({ standalone: true, selector: 'osf-header', - imports: [RouterLink, BreadcrumbComponent, MenuModule, ButtonModule], + imports: [BreadcrumbComponent, MenuModule, ButtonModule], templateUrl: './header.component.html', styleUrl: './header.component.scss', changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/src/app/core/components/nav-menu/nav-menu.component.html b/src/app/core/components/nav-menu/nav-menu.component.html index 5b8a45b74..00af45887 100644 --- a/src/app/core/components/nav-menu/nav-menu.component.html +++ b/src/app/core/components/nav-menu/nav-menu.component.html @@ -9,6 +9,7 @@ }" class="nav-link flex" [class.mt-5]="item.label === 'Settings' || item.label === 'My Projects'" + (click)="goToLink()" > @if (item.icon) { diff --git a/src/app/core/components/nav-menu/nav-menu.component.ts b/src/app/core/components/nav-menu/nav-menu.component.ts index 95dafa14d..4686067d9 100644 --- a/src/app/core/components/nav-menu/nav-menu.component.ts +++ b/src/app/core/components/nav-menu/nav-menu.component.ts @@ -1,4 +1,4 @@ -import { Component, computed, inject } from '@angular/core'; +import { Component, computed, inject, output } from '@angular/core'; import { RouterLink, RouterLinkActive, @@ -31,6 +31,8 @@ export class NavMenuComponent { this.#convertToMenuItem(item), ); + closeMenu = output(); + protected readonly currentRoute = toSignal( this.#router.events.pipe( filter((event): event is NavigationEnd => event instanceof NavigationEnd), @@ -70,4 +72,8 @@ export class NavMenuComponent { return { projectId, section }; } + + goToLink() { + this.closeMenu.emit(); + } } diff --git a/src/app/core/components/topnav/topnav.component.html b/src/app/core/components/topnav/topnav.component.html index d76ecde2c..6fff0ef9b 100644 --- a/src/app/core/components/topnav/topnav.component.html +++ b/src/app/core/components/topnav/topnav.component.html @@ -6,7 +6,7 @@ (visibleChange)="isDrawerVisible.set($event)" [closable]="false" > - + Sort by: height="13" viewBox="0 0 10 10" class="switch-icon" - (click)="switchPage(next() ?? first())" - (keydown.enter)="switchPage(next() ?? first())" + (click)="switchPage(!next() ? first() : next())" + (keydown.enter)="switchPage(!next() ? first() : next())" > - - + + + -