From 75b0cf22be9f254615d4785d09a275c659dc8d36 Mon Sep 17 00:00:00 2001 From: nsemets Date: Tue, 14 Oct 2025 19:22:53 +0300 Subject: [PATCH] fix(updates): updates for submissions --- .../collection-submission-item.component.html | 2 +- .../collection-submission-item.component.ts | 4 ++-- .../preprint-submission-item.component.html | 2 +- .../preprint-submission-item.component.ts | 4 ++-- .../registry-submission-item.component.html | 2 +- .../registry-submission-item.component.ts | 4 ++-- .../preprint-details/make-decision/make-decision.component.ts | 2 +- src/assets/i18n/en.json | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.html b/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.html index f5e0f949a..b5bfb2c65 100644 --- a/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.html +++ b/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.html @@ -48,7 +48,7 @@ @if (action.comment) { -

- {{ action.comment }}

+ } } diff --git a/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.ts b/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.ts index 4b8ed593b..01e5e221b 100644 --- a/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.ts +++ b/src/app/features/moderation/components/collection-submission-item/collection-submission-item.component.ts @@ -8,7 +8,7 @@ import { ChangeDetectionStrategy, Component, computed, inject, input } from '@an import { ActivatedRoute, Router } from '@angular/router'; import { collectionFilterNames } from '@osf/features/collections/constants'; -import { IconComponent } from '@osf/shared/components'; +import { IconComponent, TruncatedTextComponent } from '@osf/shared/components'; import { CollectionSubmissionWithGuid } from '@osf/shared/models'; import { DateAgoPipe } from '@osf/shared/pipes'; import { CollectionsSelectors } from '@osf/shared/stores'; @@ -18,7 +18,7 @@ import { SubmissionReviewStatus } from '../../enums'; @Component({ selector: 'osf-submission-item', - imports: [TranslatePipe, IconComponent, DateAgoPipe, Button], + imports: [TranslatePipe, IconComponent, DateAgoPipe, Button, TruncatedTextComponent], templateUrl: './collection-submission-item.component.html', styleUrl: './collection-submission-item.component.scss', changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html index 318026f85..6153af516 100644 --- a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html +++ b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html @@ -18,7 +18,7 @@ {{ action.creator?.name }} @if (action.comment.length) { - - {{ action.comment }} + } } diff --git a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts index b53ddc391..1c57a1de2 100644 --- a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts +++ b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts @@ -4,7 +4,7 @@ import { Button } from 'primeng/button'; import { ChangeDetectionStrategy, Component, input, output } from '@angular/core'; -import { IconComponent } from '@osf/shared/components'; +import { IconComponent, TruncatedTextComponent } from '@osf/shared/components'; import { DateAgoPipe } from '@osf/shared/pipes'; import { PREPRINT_ACTION_LABEL, ReviewStatusIcon } from '../../constants'; @@ -13,7 +13,7 @@ import { PreprintSubmission, PreprintWithdrawalSubmission } from '../../models'; @Component({ selector: 'osf-preprint-submission-item', - imports: [IconComponent, DateAgoPipe, Button, TranslatePipe], + imports: [IconComponent, DateAgoPipe, Button, TranslatePipe, TruncatedTextComponent], templateUrl: './preprint-submission-item.component.html', styleUrl: './preprint-submission-item.component.scss', changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.html b/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.html index e3f90ae2f..86c6bbef2 100644 --- a/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.html +++ b/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.html @@ -37,7 +37,7 @@

{{ submission().title }}

} @if (action.comment.length) { - - {{ action.comment }} + } } diff --git a/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.ts b/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.ts index b66958713..3f0aedf77 100644 --- a/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.ts +++ b/src/app/features/moderation/components/registry-submission-item/registry-submission-item.component.ts @@ -5,7 +5,7 @@ import { Button } from 'primeng/button'; import { DatePipe } from '@angular/common'; import { ChangeDetectionStrategy, Component, input, output } from '@angular/core'; -import { IconComponent } from '@osf/shared/components'; +import { IconComponent, TruncatedTextComponent } from '@osf/shared/components'; import { DateAgoPipe } from '@osf/shared/pipes'; import { REGISTRY_ACTION_LABEL, ReviewStatusIcon } from '../../constants'; @@ -14,7 +14,7 @@ import { RegistryModeration } from '../../models'; @Component({ selector: 'osf-registry-submission-item', - imports: [IconComponent, DateAgoPipe, Button, TranslatePipe, DatePipe], + imports: [IconComponent, DateAgoPipe, Button, TranslatePipe, DatePipe, TruncatedTextComponent], templateUrl: './registry-submission-item.component.html', styleUrl: './registry-submission-item.component.scss', changeDetection: ChangeDetectionStrategy.OnPush, diff --git a/src/app/features/preprints/components/preprint-details/make-decision/make-decision.component.ts b/src/app/features/preprints/components/preprint-details/make-decision/make-decision.component.ts index cd6d5b9fb..297cfc1ee 100644 --- a/src/app/features/preprints/components/preprint-details/make-decision/make-decision.component.ts +++ b/src/app/features/preprints/components/preprint-details/make-decision/make-decision.component.ts @@ -179,7 +179,7 @@ export class MakeDecisionComponent { const limit = formInputLimits.decisionComment.maxLength; return this.translateService.instant('preprints.details.decision.commentLengthError', { limit, - difference: Math.abs(limit - this.reviewerComment()!.length).toString(), + length: this.reviewerComment()!.length, }); }); diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json index e29e85ef0..8aa227335 100644 --- a/src/assets/i18n/en.json +++ b/src/assets/i18n/en.json @@ -2409,7 +2409,7 @@ "post": "Submission will no longer be publicly available." }, "commentPlaceholder": "Explain the reasoning behind your decision (optional)", - "commentLengthError": "Comment is {{difference}} character(s) too long (maximum is {{limit}}).", + "commentLengthError": "Comment is {{length}} character(s) too long (maximum is {{limit}}).", "withdrawalJustification": "Reason for withdrawal (optional, will be publicly displayed)", "denialJustification": "Reason for denial (required, not publicly visible)", "justificationRequiredError": "Request decision justification can't be blank",