-
Notifications
You must be signed in to change notification settings - Fork 22
[ENG-9249] Legacy wiki redirect #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nsemets
merged 4 commits into
CenterForOpenScience:feature/pbs-25.01
from
Ostap-Zherebetskyi:fix/legacy_wiki_redirect
Oct 21, 2025
+58
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8e9b045
fix(wiki): add legacy wiki redirect component and route
Ostap-Zherebetskyi 4acd35c
fix(wiki): remove standalone flag and adjust redirect method placement
Ostap-Zherebetskyi 35ea214
fix(wiki): Rename WikiRedirectComponent to LegacyWikiRedirectComponen…
Ostap-Zherebetskyi f98aff8
fix(legacy-wiki-redirect): Move loaderService.hide() to redirectWiki
Ostap-Zherebetskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
src/app/features/project/wiki/legacy-wiki-redirect.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { createDispatchMap, select } from '@ngxs/store'; | ||
|
|
||
| import { map, of, tap } from 'rxjs'; | ||
|
|
||
| import { Component, DestroyRef, inject } from '@angular/core'; | ||
| import { takeUntilDestroyed, toSignal } from '@angular/core/rxjs-interop'; | ||
| import { ActivatedRoute, Router } from '@angular/router'; | ||
|
|
||
| import { ResourceType } from '@osf/shared/enums'; | ||
| import { LoaderService } from '@osf/shared/services'; | ||
| import { GetWikiList, WikiSelectors } from '@osf/shared/stores'; | ||
|
|
||
| @Component({ | ||
| template: '', | ||
| }) | ||
| export class LegacyWikiRedirectComponent { | ||
| private readonly route = inject(ActivatedRoute); | ||
| private readonly router = inject(Router); | ||
| private readonly destroyRef = inject(DestroyRef); | ||
| private readonly loaderService = inject(LoaderService); | ||
|
|
||
| readonly projectId = toSignal(this.route.parent?.params.pipe(map((params) => params['id'])) ?? of(undefined)); | ||
| wikiList = select(WikiSelectors.getWikiList); | ||
|
|
||
| actions = createDispatchMap({ | ||
| getWikiList: GetWikiList, | ||
| }); | ||
|
|
||
| constructor() { | ||
| this.loaderService.show(); | ||
| this.redirectWiki(); | ||
| } | ||
|
|
||
| redirectWiki() { | ||
| const params = this.route.snapshot.params; | ||
| const wikiName = params['wikiName']; | ||
|
|
||
| this.actions | ||
| .getWikiList(ResourceType.Project, this.projectId()) | ||
| .pipe( | ||
| takeUntilDestroyed(this.destroyRef), | ||
| tap(() => { | ||
| const wikiGUID = this.wikiList().find((item) => item.name === wikiName)?.id ?? null; | ||
| this.router.navigate([`/${this.projectId()}/wiki`], { | ||
| queryParams: { wiki: wikiGUID }, | ||
| replaceUrl: true, | ||
| }); | ||
nsemets marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| this.loaderService.hide(); | ||
| }) | ||
| ) | ||
| .subscribe(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.