Skip to content

[ENG-8975] Redirect addons support #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 313 commits into from
Closed

[ENG-8975] Redirect addons support #690

wants to merge 313 commits into from

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 21, 2025 •
edited
Loading

  • Ticket: [ENG-8975]
  • Feature flag: n/a

Purpose

Summary of Changes

  • Add redirect addon model
  • Add new service type to existing addons enums, code, etc
  • Add support for finding redirect addon types on the addons page
  • Update addon terms page to handle redirect to redirect addon URL

Screenshot(s)

Updated Addons Terms page to show "Go to {ServiceName}" button, which should open a popup window that will take users to the URL shown at the bottom of the screen, as well as a link in the description that will take user to the same place in case the popup window is blocked
image

Side Effects

QA Notes

nmykhalkevch-exoft and others added 30 commits September 16, 2025 09:14
@nmykhalkevch-exoft
Fix/wiki (CenterForOpenScience#398)
9675eaa 
* fix(scroll): scroll to top after navigation end

* fix(scroll): scroll to top after navigation end

* fix(wiki): wiki bugs

* fix(file): file limits

* fix(wiki): responsive
@rrromchIk
Fix - Contributors permissions (CenterForOpenScience#391)
f4e9aa4 
* fix(contributors): Fixed contributors management permissions

* fix(contributors): Fixed contributors mapping for registration card
@bp-cos
fix(eng-8505): added config variable for google file picker (CenterFo…
db8b5ee 
…rOpenScience#397)
@nsemets
Fix/649 moderation tab (CenterForOpenScience#400)
0939378 
* fix(users): added 5 more columns options

* fix(summary): fixed charts numbers display

* fix(institutions): updates

* fix(users-state): removed unused code

* fix(collections): updated imports

* fix(provider): updated collection and registration providers

* fix(registry-provider): updated provider for registrations

* fix(moderation-tab): updated provider setup

* fix(tests): fixed unit tests

* fix(conflict): removed code from conflict

* fix(banner): fixed code in banner component

* fix(collections): fixed visibility of collections tab

* fix(collections): fixed subjects bug

* fix(moderators): fixed moderators and contributors search
@bp-cos
fix(datalayer): fixed to handle datalayer existence (CenterForOpenSci…
4327b60 
…ence#401)
@aaxelb
fix(metadata): correct resource type values (CenterForOpenScience#402)
12fa961
@rnastyuk
Fix(view-only-links): View only links files access issues (CenterForO…
ad51418 
…penScience#399)

* fix(view-only-links): fixed view only links files access issues

* fix(view-only-links): fixed file guid absence while redirecting

* fix(view-only-links): fixed files spec file issue
@rrromchIk
Fix - Institution dashboard bugs (CenterForOpenScience#403)
503652d 
* fix(global-search): Fixed correct order of index-card

* fix(institution-dashboard): Showing contributors sorted by permissions

* fix(institution-dashboard): Showing contributors sorted by permissions

* fix(moderators-search): Fixed searching moderators
@rnastyuk @nsemets
@mfraezz @nmykhalkevch-exoft @bp-cos @Nazar690 @dinlvkdn @rrromchIk @volodyayakubovskyy @opaduchak @adlius @mkovalua @aaxelb @sh-andriy
Fix/addons - Connect/configure logic fixes (CenterForOpenScience#408)
8425b10 
* fix(add-project-redirect-modal): added project redirect modal

* refactor(add-project-redirect-modal): added pipe to the modal subscription

* fix(addons): added logic for handling redirection after the oauth flow has finished

* fix(addons): added data attributes

* fix(addons): fixed comments

* fix(addons): fixed binding visibility change issues

* fix(addons): fixed issue with connecting citations addons

* Fix/625 view duplicates bug (CenterForOpenScience#389)

* fix(tests): fixed unit tests

* fix(bug): fixed view duplicates bug

* fix(bugs): fixed permission bug

* fix(users): added 5 more columns options (CenterForOpenScience#390)

* fix(users): added 5 more columns options

* fix(summary): fixed charts numbers display

* Fix test env SHARE url (CenterForOpenScience#393)

* Fix/wiki (CenterForOpenScience#392)

* fix(scroll): scroll to top after navigation end

* fix(scroll): scroll to top after navigation end

* fix(wiki): wiki bugs

* Feature/eslint pipeline Fixed all the lint errors and updated sentry (CenterForOpenScience#396)

* chore(eslint): added updates to eslint for the pipeline

* chore(linting): fixed some linting

* chore(error-updates): added hints to the sentry

* Fix/main to dev (CenterForOpenScience#395)

* Update develop from main (CenterForOpenScience#322)

* Fix/improvements (CenterForOpenScience#319)

* fix(meetings): fixed meetings small issues

* fix(tooltips): added tooltips

* fix(table): updated sorting

* fix(settings): fixed update project

* fix(bookmarks): updated bookmarks

* fix(my-registrations): fixed my registrations

* fix(developer-apps): fixed developer apps

* fix(settings): updated tokens and notifications

* fix(translation): removed dot

* fix(info-icon): updated info icon translate

* fix(profile-settings): fixed profile settings

* fix(test): updated tests

* fix(settings): updated settings

* fix(user-emails): updated adding emails to user account

* fix(tests): updated tests

* fix(clean-up): clean up

* fix(models): updated models

* fix(models): updated region and license models

* fix(styles): moved styles from assets

* fix(test): fixed institution loading and test for view only link

* fix(analytics): added check if is public

* fix(analytics): updated analytics feature

* fix(analytics): show message when data loaded

* fix(view-only-links): updated view only links

* fix(view only links): added shared components

* fix(tests): fixed tests

* fix(unit-tests): updated jest config

* fix(view-only-links): update view only links for components

* fix(create-view-link): added logic for uncheck

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>

* Test/387 settings page tokens (CenterForOpenScience#318)

* test(tokens): added new tests

* test(tokens): added new unit tests

* test(tokens): fixed tests and jest.config

* test(tokens): fixed pr comments

* Fix - Search (CenterForOpenScience#286)

* feat(search): added generic search component

* feat(search): improved search for institutions

* feat(search): remove unused files

* feat(search): fixed some issues

* fix(search): removed comments

* fix(profile): renamed it to profile

* fix(updates): updates

* fix(branding): Minor fixed regarding provider hero for preprints and registry

* refactor(search-results-container): Encapsulated some logic, reduced duplication

* refactor(search-results-container): Encapsulated tabs logic

* refactor(search): Refactored partly search section for preprints and profile

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for profile

* feat(profile): Implemented my-profile and user/:id pages

* refactor(preprint-provider-discover): Removed search section that uses old approach

* refactor(search): Create shared component that encapsulates search logic and reused across the app

* refactor(shared-search): Extracted state model. Reduced duplications. Fixed IndexValueSearch filters

* refactor(search): Using ResourceType instead of ResourceTab. Fixed params for index-value-search

* refactor(search-models): Cleaned up models - renamed files, moved models to appropriate locations

* refactor(index-card-search): Refactored models

* fix(resource-card): Fixed resource-card component

* fix(resource-card-secondary-metadata): Fixed resource-card component

* fix(search): Fixed PR comments and conflicts after merge

* refactor(search): Renamed OsfSearch- to GlobalSearch-

* fix(unit-tests): fixed unit tests

---------

Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: nsemets <nsemets@exoft.net>

* Fix/557 missing tooltip (CenterForOpenScience#320)

* fix(tooltip): added tooltip to next button

* fix(emails): fixed emails bug

* chore(test-env): added test env (CenterForOpenScience#321)

* Chore/test docs added more docs and updated docs in the ever expanding evolution. (CenterForOpenScience#309)

* chore(testing-docs): incremental update to the testing docs

* chore(diagram): updated the ngx application diagram

* chore(indexes): added indexes to all files

* docs(updates): added new docs and explanations

* chore(pr-updates): updated the files based on pr feedback

---------

Co-authored-by: nsemets <nsemets@exoft.net>
Co-authored-by: Nazar Semets <nazar690@gmail.com>
Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com>
Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com>
Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>

* Feat(8653): Implement view tracking for registrations and preprints (CenterForOpenScience#308)

* feat(datacite-tracker): implemented datacite view tracking for registries and preprints

* chore(datacite-tracker): refactored doi extraction to be less repetitive

* fix(datacite-tracker): reverted undesired refactor

* chore(datacite-tracker): added tests to registry component

* fix(datacite-tracker): fixed datacite tracker effect

* chore(datacite-tracker): added tests to project and preprint components

* [ENG-8624] feat(registries): add context to registration submission + rearrange title and description layout (CenterForOpenScience#304)

* feat(registries): add context to registration submission + rearrange layout

* feat(registries): CR followup

* feat(registries): Add test for TagsComponent

* feat(registries): Add moar tests

* feat(registries): CR followup

* [ENG-8504] Show Osf introduction video and Collections,Institutions, Registries, Preprints url banners if user have not created any project for home (/dashboard) tab (CenterForOpenScience#301)

* Show Osf introduction video and Collections,Institutions, Registries, Preprints url banners if user have not created any project for home (/dashboard) tab

* 1. add translations
2. add loading ( <osf-loading-spinner/>) - otherwise interface show video and afterward search (shown in details in github PR 301 video)
3. maybe there is better solution for existsProjects() || cd angular-osfsearchControl?.value?.length to check if user has at least one project

* align footer content left

* use angular routerLink approach for <a>

* add margin bottom for Visit button to look it better on resizing

* update footer formatting

* fix(dashboard): Fix [WARNING] NG8107

* fix(dashboard): remove not used variable

* fix(dashboard): fix code format by running "npm run lint:fix && npm run format"

* fix(dashboard): use .png names without guid

* implement unit testing for dashboard when there is a project and there is no project

* remove redundant footer RPCB and RCP links

* move dashboard images alt text to en.json

* add test for openInfoLink()

* update(dashboard): use dashboard.data for mocking

* update(dashboard): add test to show that products footer images no exists on spinner run and are rendering after it finished running

* fix(dashboard): npm run lint:fix && npm run format

* add missing code for dashboard

* remove redundant imports for dashboard test

* use providers -> useValue  mock approach for dashboard

* resolve CR comments

* Fix/develop conflicts (CenterForOpenScience#332)

* Fix/improvements (CenterForOpenScience#319)

* fix(meetings): fixed meetings small issues

* fix(tooltips): added tooltips

* fix(table): updated sorting

* fix(settings): fixed update project

* fix(bookmarks): updated bookmarks

* fix(my-registrations): fixed my registrations

* fix(developer-apps): fixed developer apps

* fix(settings): updated tokens and notifications

* fix(translation): removed dot

* fix(info-icon): updated info icon translate

* fix(profile-settings): fixed profile settings

* fix(test): updated tests

* fix(settings): updated settings

* fix(user-emails): updated adding emails to user account

* fix(tests): updated tests

* fix(clean-up): clean up

* fix(models): updated models

* fix(models): updated region and license models

* fix(styles): moved styles from assets

* fix(test): fixed institution loading and test for view only link

* fix(analytics): added check if is public

* fix(analytics): updated analytics feature

* fix(analytics): show message when data loaded

* fix(view-only-links): updated view only links

* fix(view only links): added shared components

* fix(tests): fixed tests

* fix(unit-tests): updated jest config

* fix(view-only-links): update view only links for components

* fix(create-view-link): added logic for uncheck

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>

* Test/387 settings page tokens (CenterForOpenScience#318)

* test(tokens): added new tests

* test(tokens): added new unit tests

* test(tokens): fixed tests and jest.config

* test(tokens): fixed pr comments

* Fix - Search (CenterForOpenScience#286)

* feat(search): added generic search component

* feat(search): improved search for institutions

* feat(search): remove unused files

* feat(search): fixed some issues

* fix(search): removed comments

* fix(profile): renamed it to profile

* fix(updates): updates

* fix(branding): Minor fixed regarding provider hero for preprints and registry

* refactor(search-results-container): Encapsulated some logic, reduced duplication

* refactor(search-results-container): Encapsulated tabs logic

* refactor(search): Refactored partly search section for preprints and profile

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for profile

* feat(profile): Implemented my-profile and user/:id pages

* refactor(preprint-provider-discover): Removed search section that uses old approach

* refactor(search): Create shared component that encapsulates search logic and reused across the app

* refactor(shared-search): Extracted state model. Reduced duplications. Fixed IndexValueSearch filters

* refactor(search): Using ResourceType instead of ResourceTab. Fixed params for index-value-search

* refactor(search-models): Cleaned up models - renamed files, moved models to appropriate locations

* refactor(index-card-search): Refactored models

* fix(resource-card): Fixed resource-card component

* fix(resource-card-secondary-metadata): Fixed resource-card component

* fix(search): Fixed PR comments and conflicts after merge

* refactor(search): Renamed OsfSearch- to GlobalSearch-

* fix(unit-tests): fixed unit tests

---------

Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: nsemets <nsemets@exoft.net>

* Fix/557 missing tooltip (CenterForOpenScience#320)

* fix(tooltip): added tooltip to next button

* fix(emails): fixed emails bug

* chore(test-env): added test env (CenterForOpenScience#321)

* Chore/test docs added more docs and updated docs in the ever expanding evolution. (CenterForOpenScience#309)

* chore(testing-docs): incremental update to the testing docs

* chore(diagram): updated the ngx application diagram

* chore(indexes): added indexes to all files

* docs(updates): added new docs and explanations

* chore(pr-updates): updated the files based on pr feedback

* Fix/registrations (CenterForOpenScience#326)

* fix(settings): updated settings routes

* fix(registry-links): updated registry links

* fix(registration): updated components, resource and links

* fix(wiki): updated wiki

* fix(redirect-link): removed it (CenterForOpenScience#327)

* [ENG-8505] Finished adding the GFP to the files page (CenterForOpenScience#325)

* feat(eng-8505): Added the initial google drive button

* feat(eng-8505): add the accountid with tests

* feat(more-tests): updated tests

* feat(eng-8505): updates for tests

* feat(eng-8505): finishing updates for the google file picker

* chore(test fixes): updates to broken tests

* chore(pr updates): add updates based on pr feedback and more docs

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>
Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com>
Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com>
Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>

* [ENG-8639] add <meta> tags to files detail (CenterForOpenScience#324)

* chore(meta-tags): cleaner meta-tag cleanup (without urls)

* chore(meta-tags): add full name to contributor tag

* feat(meta-tags): add meta tags to file-detail page

* fix(meta-tags): use image that exists

* feat(ci): separate linting from tests (CenterForOpenScience#345)

* Feat(datacite-tracker): implemented file view and  download tracking (CenterForOpenScience#335)

* feat(datacite-tracker): implemented file view and download tracking

* feat(datacite-tracker): implemented preprint version download tracking

* chore(datacite-tracker): rewritten existing tests to respect recent refactor

* chore(datacite-tracker): added tests for file downloads tracking

* chore(datacite-tracker): added tests for leftover components and pr comment fixes

* Feat(ENG-8778): Implement Cookie consent message (CenterForOpenScience#353)

* feat(cookie-consent): added toast which asks for cookie consent

* chore(cookie-consent): added tests for cookie consent

* chore(datacite-tracker): fixed review comments

* [eng-8741] Added Sentry to the app (CenterForOpenScience#340)

* chore(config-service): added a config service with tests

* feat(sentry): added sentry to the app and state-error handler with tests

* feat(promise): added a promise for application loading

* refactor(rename): renamed the files and consts to be more explicit

* feat(google-tag-manager): added a google tag manager factor

* feat(gtm): added the logic to get the google tag manager working

* feat(pr-review): add code from pr

* feat(eng-8741): added conditions if the config variables are not present

* chore(nit-pick-for-brian-g): add a gitignore

* Fix/dev to main (CenterForOpenScience#368)

* Fix/improvements (CenterForOpenScience#319)

* fix(meetings): fixed meetings small issues

* fix(tooltips): added tooltips

* fix(table): updated sorting

* fix(settings): fixed update project

* fix(bookmarks): updated bookmarks

* fix(my-registrations): fixed my registrations

* fix(developer-apps): fixed developer apps

* fix(settings): updated tokens and notifications

* fix(translation): removed dot

* fix(info-icon): updated info icon translate

* fix(profile-settings): fixed profile settings

* fix(test): updated tests

* fix(settings): updated settings

* fix(user-emails): updated adding emails to user account

* fix(tests): updated tests

* fix(clean-up): clean up

* fix(models): updated models

* fix(models): updated region and license models

* fix(styles): moved styles from assets

* fix(test): fixed institution loading and test for view only link

* fix(analytics): added check if is public

* fix(analytics): updated analytics feature

* fix(analytics): show message when data loaded

* fix(view-only-links): updated view only links

* fix(view only links): added shared components

* fix(tests): fixed tests

* fix(unit-tests): updated jest config

* fix(view-only-links): update view only links for components

* fix(create-view-link): added logic for uncheck

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>

* Test/387 settings page tokens (CenterForOpenScience#318)

* test(tokens): added new tests

* test(tokens): added new unit tests

* test(tokens): fixed tests and jest.config

* test(tokens): fixed pr comments

* Fix - Search (CenterForOpenScience#286)

* feat(search): added generic search component

* feat(search): improved search for institutions

* feat(search): remove unused files

* feat(search): fixed some issues

* fix(search): removed comments

* fix(profile): renamed it to profile

* fix(updates): updates

* fix(branding): Minor fixed regarding provider hero for preprints and registry

* refactor(search-results-container): Encapsulated some logic, reduced duplication

* refactor(search-results-container): Encapsulated tabs logic

* refactor(search): Refactored partly search section for preprints and profile

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for global, institutions page, registrations page search

* refactor(search): Refactored search logic for profile

* feat(profile): Implemented my-profile and user/:id pages

* refactor(preprint-provider-discover): Removed search section that uses old approach

* refactor(search): Create shared component that encapsulates search logic and reused across the app

* refactor(shared-search): Extracted state model. Reduced duplications. Fixed IndexValueSearch filters

* refactor(search): Using ResourceType instead of ResourceTab. Fixed params for index-value-search

* refactor(search-models): Cleaned up models - renamed files, moved models to appropriate locations

* refactor(index-card-search): Refactored models

* fix(resource-card): Fixed resource-card component

* fix(resource-card-secondary-metadata): Fixed resource-card component

* fix(search): Fixed PR comments and conflicts after merge

* refactor(search): Renamed OsfSearch- to GlobalSearch-

* fix(unit-tests): fixed unit tests

---------

Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: nsemets <nsemets@exoft.net>

* Fix/557 missing tooltip (CenterForOpenScience#320)

* fix(tooltip): added tooltip to next button

* fix(emails): fixed emails bug

* chore(test-env): added test env (CenterForOpenScience#321)

* Chore/test docs added more docs and updated docs in the ever expanding evolution. (CenterForOpenScience#309)

* chore(testing-docs): incremental update to the testing docs

* chore(diagram): updated the ngx application diagram

* chore(indexes): added indexes to all files

* docs(updates): added new docs and explanations

* chore(pr-updates): updated the files based on pr feedback

* Fix/registrations (CenterForOpenScience#326)

* fix(settings): updated settings routes

* fix(registry-links): updated registry links

* fix(registration): updated components, resource and links

* fix(wiki): updated wiki

* fix(redirect-link): removed it (CenterForOpenScience#327)

* [ENG-8505] Finished adding the GFP to the files page (CenterForOpenScience#325)

* feat(eng-8505): Added the initial google drive button

* feat(eng-8505): add the accountid with tests

* feat(more-tests): updated tests

* feat(eng-8505): updates for tests

* feat(eng-8505): finishing updates for the google file picker

* chore(test fixes): updates to broken tests

* chore(pr updates): add updates based on pr feedback and more docs

* Test/565 my projects (CenterForOpenScience#334)

* test(my-projects): added unit tests

* test(create-project-dialog): fixed errors

* test(my-projects): fixed errors

* test(create-project-dialog): fixed

* Feat/550 file widget (CenterForOpenScience#323)

* feat(file): file-widget

* feat(file): fixed move file

* Update src/app/features/project/overview/components/files-widget/files-widget.component.html

Co-authored-by: nsemets <nsemets@exoft.net>

* feat(file): resolve comments

* feat(file): refactoring

* feat(file): remove sorting storage

* feat(file): navigate to file

---------

Co-authored-by: nsemets <nsemets@exoft.net>

* Fix/metadata (CenterForOpenScience#336)

* fix(metadata): updated metadata

* fix(metadata): fixes

* fix(my-profile): fixed route

* fix(models): updated some models

* fix(tests): fixed unit tests

* chore(env): updated env files (CenterForOpenScience#328)

* chore(env): updated env files

* fix(env): updated api url

* fix(env): updated env for files widget

* fix(redirect): fixed redirect after registration (CenterForOpenScience#339)

* Test/576 analytics (CenterForOpenScience#341)

* test(analytics): added new unit tests

* test(analytics): fixed

* Feat - Admin institution filters (CenterForOpenScience#333)

* refactor(admin-institutions): Refactored and simplified code

* fix(admin-institutions): Fixed columns and sorting

* feat(institutions-projects): Implemented filters for projects tab. Fixed search result parsing

* feat(institutions-preprints): Implemented filters for preprints tab. Fixed search result parsing

* feat(institutions-registration): Implemented filters for registration tab

* fix(institutions-admin): Fixed resources to table mapping

* fix(institutions-admin): Fixed hardcoded institution iri for index-value-search

* refactor(institutions-admin-service): Extracted apiUrl to local variable

* fix(resource-model): Fix after merge conflict

* fix(institution-users): Fixed links to user

* fix(institutions-dashboard): Added translations

* fix(institutions-dashboard): Fixed tests

* fix(admin-institutions): Refactored filters to reusable component

* fix(admin-institutions): Fixed comments

* Fix - Preprints bugs (CenterForOpenScience#337)

* fix(metadata-step): Made Publication DOI field optional

* fix(preprints-landing): Contact Us button titlecased, Show example button link fixed

* fix(create-new-version): Handled back button

* fix(preprint-moderation): Fixed sorting for submissions

* fix(license-component): Clearing all fields on cancel button click

* fix(preprint-stepper): Fixed add-project-form

* Fix/affiliated institutions (CenterForOpenScience#342)

* fix(metadata): updated metadata

* fix(metadata): fixes

* fix(my-profile): fixed route

* fix(models): updated some models

* fix(tests): fixed unit tests

* fix(institutions): updated institutions

* fix(my-projects): bookmarks

* fix(institutions): updated affiliated institutions and fixed some bugs

* fix(tests): fixed tests

* fix(tests): updated if statement

* fix(bugs): fixed some bugs

* Fix/affiliated institutions (CenterForOpenScience#344)

* fix(metadata): updated metadata

* fix(metadata): fixes

* fix(my-profile): fixed route

* fix(models): updated some models

* fix(tests): fixed unit tests

* fix(institutions): updated institutions

* fix(my-projects): bookmarks

* fix(institutions): updated affiliated institutions and fixed some bugs

* fix(tests): fixed tests

* fix(tests): updated if statement

* fix(bugs): fixed some bugs

* fix(files): updated files

* Feat/185 - Linked services (CenterForOpenScience#338)

* feat(verified-links): fixed minor linked resources bugs

* feat(linked-services): added link addons configuration logic to the project settings

* feat(linked-services): added linked services page and nav tab, added link addons to settings

* feat(linked-services): fixed issues after merging

* feat(linked-services): fixed pre-push husky file

* fix(linked-services): updated tables

* feat(linked-services): added link disabling logic for storage item selector

* feat(linked-services): fixed comments and minor bugs

* feat(linked-services): fixed test issues

* feat(linked-services): fixed storage description display issue on addon terms page

* fix(recent-activity): resolved view only link addon logging issue

---------

Co-authored-by: nsemets <nsemets@exoft.net>

* Fix/clean code (CenterForOpenScience#347)

* fix(packages): removed unused packages

* fix(protected): removed protected in all files

* fix(styles): removed some mixins and scss files

* fix(classes): removed old classes

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>

* fix(file): downloads link (CenterForOpenScience#346)

* Test/580 home page (CenterForOpenScience#348)

* test(router): added route mocks

* test(router): added tests for dashboard page

* test(router): added tests for home page

* test(analytics): fixed

* Fix/overview (CenterForOpenScience#349)

* fix(add): updated add project and component dialog

* fix(move-file): updated button

* fix(overview): updated project overview

* fix(children): refactor get children request (CenterForOpenScience#351)

* Fix/overview (CenterForOpenScience#352)

* fix(add): updated add project and component dialog

* fix(move-file): updated button

* fix(overview): updated project overview

* fix(updates): clean up some code

* fix(regions): updated regions state and removed duplication

* fix(providers): updated models for providers

* fix(test): fixed unit test

* fix(bugs): fixed bugs (CenterForOpenScience#354)

* Feat(project-redirect-modal): added project redirect modal (CenterForOpenScience#350)

* fix(add-project-redirect-modal): added project redirect modal

* refactor(add-project-redirect-modal): added pipe to the modal subscription

* Test/395 institutions components (CenterForOpenScience#358)

* test(institutions): tested institutions, institutions-list, institutions-search components

* fix(tests): fixed tests

* Fix/registration bugs (CenterForOpenScience#356)

* fix(registration): fixed 594

* fix(registration-bugs): fixed some registrations bugs

* fix(registration): fixed registrations fr project

* fix(registration): remove useless font class

* fix(tags-input): Fix strange behaviour when removing first tag (CenterForOpenScience#361)

* Fix/accessibility (CenterForOpenScience#359)

* fix(accessibility): update accessibility for some pages

* fix(accessibility): added aria labels

* fix(updates): clean up code

* fix(routes): removed unused route

* fix(accessibility): added aria labels to institutions

* fix(accessibility): removed aria label for header button

* fix(metadata): fixed spacing

* fix(resource-metadata): fixed url

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>

* Fix/search filters (CenterForOpenScience#360)

* fix(global-search-filters): Resolved TODOs

* fix(global-search-filters): Fixed and simplified filters logic code

* fix(global-search-resource-card): Made links open in a new tab

* fix(global-search-filters): Added cardSearchResultCount to filter option

* fix(global-search-filters): Fixed boolean filters selected state

* fix(global-search-filters): Fixed after merge conflict

* fix(global-search-filters): Fixed PR comments

* Feat(ENG-8625): add Recent Activity to registrations (CenterForOpenScience#315)

* feat(registration-recent-activity): add Recent Activity to registrations

* feat(registration-recent-activity): code fixes regarding comments

* feat(registration-recent-activity): second round of code fixes regarding review comments

* feat(registration-recent-activity): run lint fix

* fix(recent-activity): updated some code (CenterForOpenScience#364)

* fix(errors): fixed some issues

* fix(dashboard): fixed bugs

* fix(tests): fixed unit tests

* fix(config): added error handling

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>
Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com>
Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com>
Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Co-authored-by: nmykhalkevych-exoft <nmykhalkevych@exoft.net>
Co-authored-by: Roman Nastyuk <rnastyuk@exoft.net>
Co-authored-by: sh-andriy <105591819+sh-andriy@users.noreply.github.com>

* [eng-8768] Added helpscout to various pages. (CenterForOpenScience#357)

* feat(eng-8768): add the help-scout to preprints

* feat(eng-8768): add the help-scout to projects

* feat(eng-8768): add the help-scout to registration

* feat(eng-8768): add the help-scout to settings and registries files

* feat(pr-updates): updated code based on the pr

* [ENG-8777] Add scheduled banner (CenterForOpenScience#371)

* feat(banner): Add services and models for scheduled banners

* feat(osf): Add scheduled banner

* feat(banner): CR followup

* feat(banners): CR followup again

* feat(banners): Use primeflex classesl; remove scss file

---------

Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Co-authored-by: Nazar Semets <nazar690@gmail.com>
Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com>
Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com>
Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: Oleh Paduchak <158075011+opaduchak@users.noreply.github.com>
Co-authored-by: Yuhuai Liu <yuhuai@cos.io>
Co-authored-by: mkovalua <mkoval@exoft.net>
Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
Co-authored-by: nmykhalkevych-exoft <nmykhalkevych@exoft.net>
Co-authored-by: Roman Nastyuk <rnastyuk@exoft.net>
Co-authored-by: sh-andriy <105591819+sh-andriy@users.noreply.github.com>

* Fix/wiki (CenterForOpenScience#398)

* fix(scroll): scroll to top after navigation end

* fix(scroll): scroll to top after navigation end

* fix(wiki): wiki bugs

* fix(file): file limits

* fix(wiki): responsive

* Fix - Contributors permissions (CenterForOpenScience#391)

* fix(contributors): Fixed contributors management permissions

* fix(contributors): Fixed contributors mapping for registration card

* fix(eng-8505): added config variable for google file picker (CenterForOpenScience#397)

* Fix/649 moderation tab (CenterForOpenScience#400)

* fix(users): added 5 more columns options

* fix(summary): fixed charts numbers display

* fix(institutions): updates

* fix(users-state): removed unused code

* fix(collections): updated imports

* fix(provider): updated collection and registration providers

* fix(registry-provider): updated provider for registrations

* fix(moderation-tab): updated provider setup

* fix(tests): fixed unit tests

* fix(conflict): removed code from conflict

* fix(banner): fixed code in banner component

* fix(collections): fixed visibility of collections tab

* fix(collections): fixed subjects bug

* fix(moderators): fixed moderators and contributors search

* fix(datalayer): fixed to handle datalayer existence (CenterForOpenScience#401)

* fix(metadata): correct resource type values (CenterForOpenScience#402)

* Fix(view-only-links): View only links files access issues (CenterForOpenScience#399)

* fix(view-only-links): fixed view only links files access issues

* fix(view-only-links): fixed file guid absence while redirecting

* fix(view-only-links): fixed files spec file issue

* fix(addons): fixed connect/configure button appearence and logic

---------

Co-authored-by: nsemets <nsemets@exoft.net>
Co-authored-by: mfraezz <maf7sm@virginia.edu>
Co-authored-by: nmykhalkevych-exoft <nmykhalkevych@exoft.net>
Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Co-authored-by: Nazar Semets <nazar690@gmail.com>
Co-authored-by: dinlvkdn <104976612+dinlvkdn@users.noreply.github.com>
Co-authored-by: rrromchIk <90086332+rrromchIk@users.noreply.github.com>
Co-authored-by: volodyayakubovskyy <vyakubovskyy477@gmail.com>
Co-authored-by: Oleh Paduchak <158075011+opaduchak@users.noreply.github.com>
Co-authored-by: Yuhuai Liu <yuhuai@cos.io>
Co-authored-by: mkovalua <mkoval@exoft.net>
Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
Co-authored-by: sh-andriy <105591819+sh-andriy@users.noreply.github.com>
@nsemets @Nazar690
Fix/metadata bugs (CenterForOpenScience#407)
9fdb44c 
* fix(metadata): fixed metada bugs and simplified it

* fix(registry): update registry links and components

* fix(registry-resources): fixed registry resources bugs

* fix(tests): updated tests

* fix(tags-input): fixed tags input for space

* fix(bugs): fixed some bugs

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>
@bp-cos
feat(environment): extended the environment to use config (CenterForO…
8b61ac4 
…penScience#406)
@bp-cos
fix(helpscout): added the help-scout to the preprint-details page (Ce…
95c8df9 
…nterForOpenScience#405)
@bp-cos
Bug fix/config service (CenterForOpenScience#411)
befe2dc 
* fix(test): fixed missed refactors and tests

* refactor(bad-merge): there was a bad merge and mistake naming
@bp-cos
fix(window): fixed the window typing (CenterForOpenScience#412)
76adbaf
@nsemets
fix(recaptcha-key): update recaptcha key (CenterForOpenScience#410)
4bf4773
@bp-cos
Updated the environment files and angular.json to be correct (CenterF…
3df36b1 
…orOpenScience#413)

* chore(environments): updated the environment files

* chore(environments): replaced the environment files
@bp-cos
Updates to the jest file (CenterForOpenScience#414)
824a172 
* chore(jest): updates to the jest file

* chore(jest): updates to the jest file
@nmykhalkevch-exoft
Fix/registry bug (CenterForOpenScience#415)
a13ece5 
* fix(registration): fixed 594

* fix(registration-bugs): fixed some registrations bugs

* fix(registration): fixed registrations fr project

* fix(registration): remove useless font class

* fix(subjects): refactor subjects for project and registration

* fix(subjects): fixed subjects search

* fix(bugs): fixed 426

* fix(bugs): add some area labels

* fix(bugs): files upload limits

* fix(registration): show data for admin
@nsemets @Nazar690
fix(bugs): fixed bugs (CenterForOpenScience#417)
7900629 
Co-authored-by: Nazar Semets <nazar690@gmail.com>
@nsemets @Nazar690
Fix/profile updates (CenterForOpenScience#362)
00a134e 
* fix(accessibility): update accessibility for some pages

* fix(accessibility): added aria labels

* fix(updates): clean up code

* fix(routes): removed unused route

* fix(accessibility): added aria labels to institutions

* fix(accessibility): removed aria label for header button

* fix(metadata): fixed spacing

* fix(profile): combined user and my profiles into one

* fix(profile): updated profile links

* fix(profile): fixed styles

---------

Co-authored-by: Nazar Semets <nazar690@gmail.com>
@rrromchIk
Fix - Preprints bugs (CenterForOpenScience#409)
6c8e1fd 
* fix(metadata-step): Made Publication DOI field optional

* fix(preprints-landing): Contact Us button titlecased, Show example button link fixed

* fix(create-new-version): Handled back button

* fix(preprint-moderation): Fixed sorting for submissions

* fix(license-component): Clearing all fields on cancel button click

* fix(preprint-stepper): Fixed add-project-form

* fix(preprint-title): Increased title maxLength to 512 chars

* fix(preprint-details): Fixed date format for download prev version dropdown

* fix(preprint-details): Fixed created and last edited dates value

* fix(preprint-links): Made institution and license help guide links open in a new tab

* fix(affiliated-institutions): Added tooltip containing  institution name

* fix(file-step): Fixed label

* fix(affiliated-institution-select): Fixed description links

* fix(preprint-contributors): Fixed contributors links

* fix(preprint-user-permissions): Only admin contributor can edit author assertions

* fix(contributors-list): Implemented permissions for managing contributors

* fix(search): Fixed small bug regarding search

* fix(contributors): Fixed PR comments

* fix(preprint-file-section): Fixed version number for file

* fix(preprint-file-section): Added cancel button to reset file source option

* fix(preprint-file-section): Added file section for edit and resubmit flow

* fix(preprint-moderation): Improved sorting order

* fix(supplements-step): Fixed labels for buttons

* fix(preprint-provider-brand): Fixed parsing brand

* fix(institution-dashboard): Limited contributors to top 2

* fix(supplements-step): Removed unused import

* fix(comments): Fixed PR comments

* fix(affiliated-institutions): Fixed description for metadata step
@nsemets
Fix/env updates (CenterForOpenScience#418)
d2c87ec 
* fix(env): updated environment

* fix(tests): fixed unit tests

* fix(bugs): fixed bugs
@bp-cos
feat(eng-8901): consolidate the osf banners into 1 component (CenterF…
362a1c4 
…orOpenScience#416)

* chore(merge-conflicts): fixed merge conflicts

* chore(merge-conflicts): fixed merge conflicts - 2
@nsemets
fix(bugs): fixed ui bugs (CenterForOpenScience#419)
76bee17
@mkovalua
[ENG-8951] fix(tos-banner): tos banner unit test implementation (Cent…
af31dd0 
…erForOpenScience#404)

* fix(tos-banner): tos banner unit test implementation

* fix(tos banner): unit test implementation, set mock user value  acceptedTermsOfService: false

* fix(tos banner): update currentUser into localstorage on 'acceptedTermsOfService' set to true
@rrromchIk
fix(global-search): Fixed bugs (CenterForOpenScience#420)
380e584
@nsemets
fix(resources): fixed bugs (CenterForOpenScience#423)
e651d90
@rrromchIk
Fix - search bugs (CenterForOpenScience#422)
168f6e0 
* fix(global-search): Fixed bugs

* fix(global-search): Fixed error when no search results

* fix(submissions-sort): Fixed sorting for registration submissions

* fix(institution-dashboard): Added overflow ellipsis for long column content

* fix(global-search): Fixed order of applying filters
@rrromchIk
fix(tags): Made tags clickable for project and registry overview (Cen…
b013628 
…terForOpenScience#427)
@bp-cos
Refactor for the schedule banner (CenterForOpenScience#424)
7834591 
* feat(scheduled-banner): refactored and tested the scheduled banner

* chore(testing): added tests for scheduled banner

* chore(update-tests): updated tests and had to skip tests to

* fix(pr): fixed a pr request
rnastyuk and others added 22 commits October 11, 2025 14:04
@rnastyuk
fix(delete-component): fixed delete component modal behavior (CenterF…
b6e5d31 
…orOpenScience#630)
@nmykhalkevch-exoft
fix(prod-bugs): wiki and hide copy file action (CenterForOpenScience#629
4642e30 
)
@rnastyuk
Fix/delete component modal (CenterForOpenScience#631)
8aa5b8d 
* fix(delete-component): fixed delete component modal behavior

* fix(delete-component): fixed undefined error
@rnastyuk
Fix/VOLs (CenterForOpenScience#632)
623a8bf 
* fix(delete-component): fixed delete component modal behavior

* fix(delete-component): fixed undefined error

* fix(view-only-links): fixed component list displaying
@nsemets
fix(sorting): added sorting for employment and education (CenterForOp…
0cced73 
…enScience#633)
@nsemets
fix(components): updated pagination (CenterForOpenScience#634)
5bfb031
@nsemets
fix(contributors): fixed delete myself as contributor (CenterForOpenS…
6cfb3ff 
…cience#635)
@nmykhalkevch-exoft
Fix/prod hot fixes (CenterForOpenScience#636)
e09fdcf 
* fix(prod-bugs): wiki and hide copy file action

* fix(wiki): pagination
@nsemets
fix(developer-apps): fixed bug (CenterForOpenScience#637)
e8ce797
@adlius
fix(collection): use is_public and bookmarks filter for node collecti…
5be07aa 
…ons (CenterForOpenScience#638)
@rnastyuk
Fix/Addons - Google Drive Connection (CenterForOpenScience#640)
dd899a0 
* fix(delete-component): fixed delete component modal behavior

* fix(delete-component): fixed undefined error

* fix(view-only-links): fixed component list displaying

* fix(addons): google drive fix
@nsemets
fix(toggle-publicity): fixed bug (CenterForOpenScience#639)
b3137eb
@rrromchIk
fix(review-step): Handle optional chaining for preprint file ID (Cent…
ca872e3 
…erForOpenScience#641)
@nmykhalkevch-exoft
Fix/prod hot fixes (CenterForOpenScience#642)
a9fab73 
* fix(prod-bugs): wiki and hide copy file action

* fix(wiki): pagination

* fix(pipe): fixed special char
@rrromchIk
fix(global-search): Normalize quotes in search text input for global-…
69b7323 
…search (CenterForOpenScience#643)
@rnastyuk
fix(addons): changed description text (CenterForOpenScience#644)
617241c
@nsemets
Fix/1032 bug (CenterForOpenScience#645)
cce3286 
* fix(password): updated password hint

* fix(password): updated password styles
@nsemets
refactor(root): changed name from root to layout (CenterForOpenScienc…
1cf5f00 
…e#647)
@nmykhalkevch-exoft
fix(bugs): ang-1026 fixed (CenterForOpenScience#649)
f19350e
@mkovalua
fix( ANG-1027 ): update registation remarksPlaceholder (CenterForOpen…
c3d21bf 
…Science#646)
@futa-ikeda
feat(addons): Allow fetching redirect addons
bfeea5e
@futa-ikeda
feat(addons): Update terms page for redirect addons
5bcb3d4
@futa-ikeda futa-ikeda changed the base branch from develop to main October 21, 2025 13:48
nsemets
nsemets reviewed Oct 21, 2025
View reviewed changes
src/app/shared/components/addons/addon-terms/addon-terms.component.ts Outdated
Comment on lines 22 to 24
isRedirectService = computed(() => {
return isRedirectAddon(this.addon());
});
Copy link
Collaborator

@nsemets nsemets Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isRedirectService = computed(() => {
return isRedirectAddon(this.addon());
});
isRedirectService = computed(() => isRedirectAddon(this.addon()));

...ect/project-addons/components/connect-configured-addon/connect-configured-addon.component.ts Outdated
this.router.navigate([`${this.baseUrl()}/addons`]);
newWindow.focus();
} else {
this.toastService.showError('addons.redirect.pop-up-error');
Copy link
Collaborator

@nsemets nsemets Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.toastService.showError('addons.redirect.pop-up-error');
this.toastService.showError('addons.redirect.popUpError');

Use camelCase.

@futa-ikeda futa-ikeda changed the title Redirect addons support [ENG-8975] Redirect addons support Oct 21, 2025
@brianjgeiger
Copy link
Contributor

brianjgeiger commented Oct 22, 2025

@futa-ikeda Please rebase on centerforopenscience:feature/pbs-25.02

@futa-ikeda futa-ikeda changed the base branch from main to feature/pbs-25.02 October 22, 2025 15:07
@futa-ikeda
Copy link
Contributor Author

futa-ikeda commented Oct 22, 2025

closing in favor of #696

@futa-ikeda futa-ikeda closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsemets nsemets nsemets left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.