From ef78fb26b1042995f64b53a1e5686d4601bd2c14 Mon Sep 17 00:00:00 2001 From: mkovalua Date: Wed, 5 Nov 2025 19:29:08 +0200 Subject: [PATCH 1/3] navigateToPreprint with guid in url to avoid error --- .../preprint-withdrawal-submissions.component.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts b/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts index 7dd69df25..1cb9ea9a3 100644 --- a/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts +++ b/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts @@ -118,7 +118,9 @@ export class PreprintWithdrawalSubmissionsComponent implements OnInit { navigateToPreprint(item: PreprintWithdrawalSubmission) { const url = this.router.serializeUrl( - this.router.createUrlTree(['/preprints/', this.providerId(), item.id], { queryParams: { mode: 'moderator' } }) + this.router.createUrlTree(['/preprints/', this.providerId(), item.preprintId], { + queryParams: { mode: 'moderator' }, + }) ); window.open(url, '_blank'); From d3f778cd8e53532b9f3f775c3e5f32d1607c1036 Mon Sep 17 00:00:00 2001 From: mkovalua Date: Wed, 5 Nov 2025 21:10:21 +0200 Subject: [PATCH 2/3] not render Withdrawal/Submission Request Moderation and data if 'machine_state' is null --- .../preprint-submissions/preprint-submissions.component.ts | 2 ++ .../preprint-withdrawal-submissions.component.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.ts b/src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.ts index f4fe157e8..af97cb132 100644 --- a/src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.ts +++ b/src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.ts @@ -97,6 +97,8 @@ export class PreprintSubmissionsComponent implements OnInit { } changeReviewStatus(value: SubmissionReviewStatus): void { + if (!value) return; + this.selectedReviewOption.set(value); this.router.navigate([], { relativeTo: this.route, diff --git a/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts b/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts index 1cb9ea9a3..e8b38dcbe 100644 --- a/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts +++ b/src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.ts @@ -94,6 +94,8 @@ export class PreprintWithdrawalSubmissionsComponent implements OnInit { } changeReviewStatus(value: SubmissionReviewStatus): void { + if (!value) return; + this.selectedReviewOption.set(value); this.router.navigate([], { relativeTo: this.route, From 02a9b60ca447411be84d8d29dcf5af9e2108d4a5 Mon Sep 17 00:00:00 2001 From: mkovalua Date: Wed, 5 Nov 2025 21:28:41 +0200 Subject: [PATCH 3/3] avoid wrong encoding of < > & for preprint submission item --- .../preprint-submission-item.component.html | 2 +- .../preprint-submission-item.component.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html index ab1ad39ef..6542e9d12 100644 --- a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html +++ b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.html @@ -10,7 +10,7 @@ class="link-btn-no-padding" styleClass="text-left" link - [label]="submission().title" + [label]="submission().title | fixSpecialChar" (onClick)="selected.emit()" /> @for (action of showAll ? submission().actions : submission().actions.slice(0, limitValue); track $index) { diff --git a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts index 35e537c49..a20e7b46f 100644 --- a/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts +++ b/src/app/features/moderation/components/preprint-submission-item/preprint-submission-item.component.ts @@ -10,6 +10,7 @@ import { IconComponent } from '@osf/shared/components/icon/icon.component'; import { TruncatedTextComponent } from '@osf/shared/components/truncated-text/truncated-text.component'; import { StopPropagationDirective } from '@osf/shared/directives/stop-propagation.directive'; import { DateAgoPipe } from '@osf/shared/pipes/date-ago.pipe'; +import { FixSpecialCharPipe } from '@osf/shared/pipes/fix-special-char.pipe'; import { PREPRINT_ACTION_LABEL, ReviewStatusIcon } from '../../constants'; import { ActionStatus, SubmissionReviewStatus } from '../../enums'; @@ -29,6 +30,7 @@ import { PreprintSubmissionModel, PreprintWithdrawalSubmission } from '../../mod AccordionContent, ContributorsListComponent, StopPropagationDirective, + FixSpecialCharPipe, ], templateUrl: './preprint-submission-item.component.html', styleUrl: './preprint-submission-item.component.scss',