[EMB-164] Show Popular contributors #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
previously requested changes
Mar 5, 2018
Member
jamescdavis
left a comment
jamescdavis
left a comment
There was a problem hiding this comment.
We actually have a test for this! It needs to updated too.
binoculars
approved these changes
Mar 6, 2018
aaxelb
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the New and Noteworthy as well as the Popular project lists show contributors on the dashboard
Summary of Changes
Pass the contributor information into the contributor list components instead of, say, the node information.
Before:
After:
Side Effects / Testing Notes
Should be side-effect free.
Ticket
https://openscience.atlassian.net/browse/EMB-164
Reviewer Checklist
CHANGELOG.md