[ENG-2771] Unencode special characters in Registries Custom Metadata #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
requested changes
May 4, 2021
Contributor
futa-ikeda
left a comment
futa-ikeda
left a comment
There was a problem hiding this comment.
I think a small test file in tests/integration/helpers/fix-string-test.ts to assert that those special characters are getting converted would be beneficial as well
adlius
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure that special characters like
<,>, and&do not render as their encoded version in the display of the Registries custom metadata field. Note that this does not affect the edit field, because the text in the helper couldn't be overridden without breaking it.Summary of Changes
Side Effects
This is very isolated, so there should be no side effects.
QA Notes
This affects the registries overview page, when there is custom metadata that has
&,<, or>coming from the OSF, which happens if you try to save&,<, or>to the field.