Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/app-components/addon/helpers/fix-string.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import Helper from '@ember/component/helper';
import fixSpecialChars from 'ember-osf-web/utils/fix-special-char';

export default class FixString extends Helper {
compute([textToFix]: [string]): string {
return fixSpecialChars(textToFix);
}
}
1 change: 1 addition & 0 deletions lib/app-components/app/helpers/fix-string.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default } from 'app-components/helpers/fix-string';
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
data-test-registration-provider-metadata-field-value={{@field.field_name}}
local-class='ProviderMetadataValue'
>
{{@field.field_value}}
{{fix-string @field.field_value}}
</span>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';
import { setupEngineRenderingTest } from 'ember-osf-web/tests/helpers/engines';
import { module, test } from 'qunit';

module('Integration | Helper | fix-string', hooks => {
setupEngineRenderingTest(hooks, 'registries');

test('it renders', async function(assert) {
await render(hbs`
{{fix-string 'Unchanging &lt; &amp; &gt;'}}
`);

assert.dom(this.element).hasText('Unchanging < & >');
});
});
4 changes: 2 additions & 2 deletions tests/engines/registries/acceptance/overview/overview-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ module('Registries | Acceptance | overview.overview', hooks => {
provider: server.schema.registrationProviders.find('osf'),
providerSpecificMetadata: [
{ field_name: 'Field 1', field_value: '' },
{ field_name: 'Field 2', field_value: 'Value 2' },
{ field_name: 'Field 2', field_value: 'Value 2 &lt; &amp; &gt;' },
],
});
const regTwo = server.create('registration', {
Expand Down Expand Up @@ -496,7 +496,7 @@ module('Registries | Acceptance | overview.overview', hooks => {
assert.dom('[data-test-registration-provider-metadata-wrapper="Field 2"]')
.isVisible('Non moderator can see the field 2 display component');
assert.dom('[data-test-registration-provider-metadata-field-value="Field 2"')
.containsText('Value 2', 'Non-moderator field two has the correct value');
.containsText('Value 2 < & >', 'Non-moderator field two has the correct value');

await visit(`/${regTwo.id}/`);
assert.dom('[data-test-edit-button="metadata"]').isVisible('Moderator can edit provider metadata');
Expand Down