Skip to content

Conversation

@jamescdavis
Copy link
Member

@jamescdavis jamescdavis commented Mar 22, 2018

Purpose

Fix issue where share url query string is double encoded

Summary of Changes

Remove encodeURIComponent() on file download url

Side Effects / Testing Notes

Make sure share link is valid

Ticket

N/A

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@aaxelb
Copy link
Contributor

aaxelb commented Mar 22, 2018

Minor: It's not a SHARE link, just a share link. No need to shout. 😄

@jamescdavis
Copy link
Member Author

Weird. Muscle memory?

@jamescdavis
Copy link
Member Author

@coveralls
Copy link

Coverage Status

Coverage remained the same at 21.122% when pulling 2254d18 on jamescdavis:no-double-encode-mfr-url into 27d7833 on CenterForOpenScience:develop.

@jamescdavis jamescdavis merged commit cb22549 into CenterForOpenScience:develop Mar 22, 2018
@jamescdavis jamescdavis deleted the no-double-encode-mfr-url branch March 22, 2018 17:00
@jamescdavis jamescdavis added this to the 0.3.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants