[ENG-3105] Bulk upload widget, with acceptance tests. #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UploadCSV component * bulk upload widget * err modals * add moar msgs * bump ember-template-lint version; add toast msg * fix tests
Pull Request Test Coverage Report for Build 1281836326
💛 - Coveralls |
fabmiz
reviewed
Sep 27, 2021
Member
fabmiz
left a comment
fabmiz
left a comment
There was a problem hiding this comment.
Looks great 💯 Minor suggestion. I am also not sure why yarn.lock was updated, could you not commit the update.
Comment on lines
3
to
13
| @buildUrl={{action this.buildUrl}} | ||
| @options={{this.dropzoneOptions}} | ||
| @dropzone={{false}} | ||
| @addedfile={{action this.addedFile}} | ||
| @uploadprogress={{action this.uploadProgress}} | ||
| @success={{action this.success}} | ||
| @error={{action this.error}} | ||
| @dragenter={{action (mut this.dropping) true}} | ||
| @dragover={{action (mut this.dropping) true}} | ||
| @drop={{action (mut this.dropping) false}} | ||
| @dragleave={{action (mut this.dropping) false}} |
Member
There was a problem hiding this comment.
Suggested change
| @buildUrl={{action this.buildUrl}} | |
| @options={{this.dropzoneOptions}} | |
| @dropzone={{false}} | |
| @addedfile={{action this.addedFile}} | |
| @uploadprogress={{action this.uploadProgress}} | |
| @success={{action this.success}} | |
| @error={{action this.error}} | |
| @dragenter={{action (mut this.dropping) true}} | |
| @dragover={{action (mut this.dropping) true}} | |
| @drop={{action (mut this.dropping) false}} | |
| @dragleave={{action (mut this.dropping) false}} | |
| @buildUrl={{this.buildUrl}} | |
| @options={{this.dropzoneOptions}} | |
| @dropzone={{false}} | |
| @addedfile={{this.addedFile}} | |
| @uploadprogress={{this.uploadProgress}} | |
| @success={{this.success}} | |
| @error={{this.error}} | |
| @dragenter={{fn (mut this.dropping) true}} | |
| @dragover={{fn (mut this.dropping) true}} | |
| @drop={{fn (mut this.dropping) false}} | |
| @dragleave={{fn (mut this.dropping) false}} |
Contributor
Author
yarn.lock is updated to update |
Contributor
Author
|
Closed in favor of #1307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR enables admins of registration providers to upload a CSV file and create registrations in bulk.
Summary of Changes
PLACEHOLDER
Screenshot(s)
Side Effects
QA Notes