From 0ea2698556f2707d178fd10c159fdc623dba3841 Mon Sep 17 00:00:00 2001
From: Brian Geiger <bgeiger@cos.io>
Date: Wed, 29 Sep 2021 09:39:58 -0400
Subject: [PATCH 1/2] Fix accessibility problems on collections submission page

---
 .../project-contributors/list/item/template.hbs    | 14 +++++++-------
 .../project-contributors/search/template.hbs       |  2 ++
 .../components/submit-section/active/styles.scss   |  2 +-
 translations/en-us.yml                             |  1 +
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/lib/app-components/addon/components/project-contributors/list/item/template.hbs b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
index 729db0b00be..cce8cf59a9b 100644
--- a/lib/app-components/addon/components/project-contributors/list/item/template.hbs
+++ b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
@@ -58,13 +58,13 @@
     {{! Bibliographic (Citation) }}
     <div data-test-project-contributors-list-item-citation-checkbox local-class='text-sm-center'
         class='col-xs-10 col-sm-2 col-sm-offset-0 bib-padding'>
-        <label local-class='checkbox-label' class='visible-xs-inline' for='{{@contributor.id}}-citation'>
-            <em>
-                {{t 'app_components.project_contributors.list.item.in_citation_label'}}
-            </em>
-        </label>
-        <Input @id={{concat @contributor.id '-citation'}} @type='checkbox' @disabled={{not this.canChangeBibliographic}}
-            @checked={{@contributor.bibliographic}} @change={{action @toggleBibliographic @contributor}} />
+        <Input
+            aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
+            @id={{concat @contributor.id '-citation'}}
+            @type='checkbox'
+            @disabled={{not this.canChangeBibliographic}}
+            @checked={{@contributor.bibliographic}}
+            @change={{action @toggleBibliographic @contributor}} />
     </div>
 
     {{! Remove }}
diff --git a/lib/app-components/addon/components/project-contributors/search/template.hbs b/lib/app-components/addon/components/project-contributors/search/template.hbs
index 7264bee1182..294ced6d181 100644
--- a/lib/app-components/addon/components/project-contributors/search/template.hbs
+++ b/lib/app-components/addon/components/project-contributors/search/template.hbs
@@ -5,6 +5,7 @@
         class='input-group'
     >
         <Input
+            aria-label={{t 'app_components.project_contributors.search.placeholder'}}
             @class='form-control'
             @value={{this.query}}
             @placeholder={{t 'app_components.project_contributors.search.placeholder'}}
@@ -12,6 +13,7 @@
         <span class='input-group-btn'>
             <button
                 data-test-project-contributors-search-button
+                aria-label={{t 'app_components.project_contributors.search.perform_search'}}
                 local-class='authors-search-button'
                 class='btn btn-default'
                 type='submit'
diff --git a/lib/app-components/addon/components/submit-section/active/styles.scss b/lib/app-components/addon/components/submit-section/active/styles.scss
index 58b8a0cc4c8..a9035e9c184 100644
--- a/lib/app-components/addon/components/submit-section/active/styles.scss
+++ b/lib/app-components/addon/components/submit-section/active/styles.scss
@@ -1,5 +1,5 @@
 .closed {
-    color: #888;
+    color: $color-text-black;
 }
 
 .green {
diff --git a/translations/en-us.yml b/translations/en-us.yml
index 7a73229f526..52a48678687 100644
--- a/translations/en-us.yml
+++ b/translations/en-us.yml
@@ -776,6 +776,7 @@ app_components:
                 add: Add
             add_contributor_success: 'Project contributor added!'
             add_contributor_error: 'Could not add contributor.'
+            perform_search: 'Perform search'
     project_metadata:
         field_title_label: 'Title:'
         field_title_placeholder: ""

From 2da0b06b3a2d215162f3632c12c2126c212cbe3b Mon Sep 17 00:00:00 2001
From: Brian Geiger <bgeiger@cos.io>
Date: Thu, 4 Nov 2021 14:57:47 -0400
Subject: [PATCH 2/2] Remove unused code

---
 .../components/project-contributors/list/item/styles.scss    | 5 -----
 .../components/project-contributors/list/item/template.hbs   | 1 -
 2 files changed, 6 deletions(-)

diff --git a/lib/app-components/addon/components/project-contributors/list/item/styles.scss b/lib/app-components/addon/components/project-contributors/list/item/styles.scss
index a4f6a763cd8..f18e2010cef 100644
--- a/lib/app-components/addon/components/project-contributors/list/item/styles.scss
+++ b/lib/app-components/addon/components/project-contributors/list/item/styles.scss
@@ -37,11 +37,6 @@
     height: 30px;
 }
 
-.checkbox-label {
-    font-weight: normal;
-    padding-right: 5px;
-}
-
 @media (min-width: 768px) {
     .text-sm-center {
         text-align: center;
diff --git a/lib/app-components/addon/components/project-contributors/list/item/template.hbs b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
index cce8cf59a9b..0d6b01378be 100644
--- a/lib/app-components/addon/components/project-contributors/list/item/template.hbs
+++ b/lib/app-components/addon/components/project-contributors/list/item/template.hbs
@@ -60,7 +60,6 @@
         class='col-xs-10 col-sm-2 col-sm-offset-0 bib-padding'>
         <Input
             aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
-            @id={{concat @contributor.id '-citation'}}
             @type='checkbox'
             @disabled={{not this.canChangeBibliographic}}
             @checked={{@contributor.bibliographic}}