From 3c4ccf7646253ee2375b31a7c27b7635663ed6f1 Mon Sep 17 00:00:00 2001 From: Yuhuai Liu Date: Tue, 12 Oct 2021 15:47:33 -0400 Subject: [PATCH] show correct message when isOriginalResponse --- .../registries/version-metadata/template.hbs | 10 ++++++---- .../registries/version-metadata/component-test.ts | 3 ++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/osf-components/addon/components/registries/version-metadata/template.hbs b/lib/osf-components/addon/components/registries/version-metadata/template.hbs index 76202a57175..b524678a562 100644 --- a/lib/osf-components/addon/components/registries/version-metadata/template.hbs +++ b/lib/osf-components/addon/components/registries/version-metadata/template.hbs @@ -6,17 +6,19 @@ local-class='versionMetadata-title' > {{#if @revision}} - {{if (gt @revision.revisionNumber 0) (t 'registries.overview.versionMetadata.updateTitle') (t 'registries.overview.versionMetadata.originalTitle')}} + {{if @revision.isOriginalResponse (t 'registries.overview.versionMetadata.originalTitle') (t 'registries.overview.versionMetadata.updateTitle')}} {{else}} {{if (gt @registration.schemaResponses.length 1) (t 'registries.overview.versionMetadata.updateTitle') (t 'registries.overview.versionMetadata.originalTitle')}} {{/if}}

{{!-- TODO: add description for what fields have changed --}}

- {{if @revision.revisionNumber (t 'registries.overview.versionMetadata.date' date=(moment-format @revision.date 'MMM DD, YYYY')) - (t 'registries.overview.versionMetadata.originalDate' date=(moment-format @revision.date 'MMM DD, YYYY'))}} + {{if @revision.isOriginalResponse + (t 'registries.overview.versionMetadata.originalDate' date=(moment-format @revision.date 'MMM DD, YYYY')) + (t 'registries.overview.versionMetadata.date' date=(moment-format @revision.date 'MMM DD, YYYY')) + }}

- {{#if @revision}} + {{#if (and @revision (not @revision.isOriginalResponse))}}

{{t 'registries.overview.versionMetadata.reason'}}
diff --git a/tests/integration/components/registries/version-metadata/component-test.ts b/tests/integration/components/registries/version-metadata/component-test.ts index ca4f9ee9651..30f39520c43 100644 --- a/tests/integration/components/registries/version-metadata/component-test.ts +++ b/tests/integration/components/registries/version-metadata/component-test.ts @@ -21,6 +21,7 @@ module('Integration | Component | version-metadata', hooks => { registrationResponses: { q1: 'Clark Kent' }, }); const revision = server.create('schema-response', { + isOriginalResponse: true, initiatedBy: currentUser, dateModified: new Date(), revisionJustification: 'This registration went into a phone booth', @@ -38,6 +39,6 @@ module('Integration | Component | version-metadata', hooks => { }), 'revision initiator is shown', ); assert.dom('[data-test-version-metadata-reason]') - .hasTextContaining(revision.revisionJustification, 'revision justification is shown'); + .doesNotExist(); }); });