Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Sep 1, 2022

Purpose

  • Remove some of the complexities around how we use brand colors and images in the registries header

Summary of Changes

  • Remove the logic pertaining to how we show brand color/images on the registries header, so the only thing shown in the header will just be the brand's hero image
  • Accessibility/color contrast on branded registry pages is gonna be a little whacky until we change the brand assets to a more appropriate color

Screenshot(s)

  • A lot of the external registries will look funny until their brand assets are updated, so I imagine most registries won't look good until those images are updated

  • Before (Solid brand primary color background with 40% opacity and greyscaled image on top) :
    image

  • After (Just the image, no greyscale or opacity) :
    image

Side Effects

  • Community-operated registries will need to go over their branding and update the logos/banner images accordingly

QA Notes

  • We have a number of community operated registries and their assets will need to be updated to have sufficient color contrast

Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@futa-ikeda futa-ikeda added this to the 22.9.0 milestone Sep 1, 2022
@coveralls
Copy link

coveralls commented Sep 1, 2022

Pull Request Test Coverage Report for Build 3023252619

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.302%

Totals Coverage Status
Change from base Build 3023240060: 0.0%
Covered Lines: 5385
Relevant Lines: 7338

💛 - Coveralls

@futa-ikeda futa-ikeda merged commit 1428cf8 into CenterForOpenScience:develop Sep 9, 2022
@futa-ikeda futa-ikeda deleted the simplify-overview-header branch September 9, 2022 15:09
chth0n1x pushed a commit to chth0n1x/ember-osf-web that referenced this pull request Feb 1, 2023
…rOpenScience#1647)

-   Ticket: [ENG-3748]
-   Feature flag: n/a

## Purpose
- Remove some of the complexities around how we use brand colors and images in the registries header

## Summary of Changes
- Remove the logic pertaining to how we show brand color/images on the registries header, so the only thing shown in the header will just be the brand's hero image 
- Accessibility/color contrast on branded registry pages is gonna be a little whacky until we change the brand assets to a more appropriate color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants