Skip to content

Make dialog box scroll on overflow #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Make dialog box scroll on overflow #1649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df9474
Make dialog box scroll on overflow
brianjgeiger Sep 2, 2022
57ecf78
Merge branch 'develop' into feature/better-dialog-for-links
brianjgeiger Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/analytics-page/addon/application/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
margin-top: 20px;
}

:global(.modal-body) {
Copy link
Contributor

@futa-ikeda futa-ikeda Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instinctively, the application of this global class makes me nervous, but it's just limited to the analytics engine it seems and it makes sure any additional BsModal doesn't suffer from the no-scroll behavior... I'm torn, but I think it's good.

max-height: 80vh;
overflow: scroll;
}

.CountBox {
text-align: center;

Expand Down