[SVCS-159] Fix Extension Names in Renderer and Exporter #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get_renderer_name() and get_exporter_name() take self.metadata.ext as the ext name. Must convert it to lower case to find the renderer/exporter.
cslzchen
force-pushed
the
fix/fix-renderer-and-exporter-names
branch
from
f83ce64 to
39ebdca
Compare
- Improve code and comments - Fix tests
cslzchen
force-pushed
the
fix/fix-renderer-and-exporter-names
branch
from
39ebdca to
a0c694e
Compare
cslzchen
commented
Mar 20, 2018
| return list(entry_attrs)[0].attrs[0] | ||
| # `ep_iterator` is an iterable object. Must convert it to a `list` for access. | ||
| # `list()` can only be called once because the iterator moves to the end after conversion. | ||
| ep_iterator = pkg_resources.iter_entry_points(group='mfr.renderers', name=name.lower()) |
Contributor
Author
There was a problem hiding this comment.
For both exporter and renderer, the primary functional change is name=name.lower().
|
|
||
| def get_exporter_name(name): | ||
| # If file type is supported, there must be only one element in the list. | ||
| assert len(ep_list) == 1 |
Contributor
Author
There was a problem hiding this comment.
For both exporter and renderer, use assert for functionalities that are not expected to break.
cslzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-159
Purpose
#296 breaks files of which the extension names are not lower case. This PR fix the issue.
Changes
name->name.lower()get_renderer_name()andget_exporter_name()Side effects
No
QA Notes
No
Deployment Notes
No