[SVCS-674][PLAT-218] Relay MFR header requests to WB #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
Contributor
|
This seems fine to me. Only thing to be aware of is that this happens - would it be worth putting in documentation that any requests to mfr forward all headers to the third parties where the file is hosted? |
Member
|
After an in-person discussion with @Johnetordoff, we've decided to close this PR and continue the work in a new one. Instead of relaying all the headers/request metadata, we'll relay the important ones (referrer and request url) in specially named headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
SVCS-674
https://openscience.atlassian.net/browse/PLAT-709
Purpose
Currently the MFR doesn't pass any useful information about the render back to the osf. This fix in conjunction with CenterForOpenScience/waterbutler#324 will allow osf.io to receive information more information about how a file was received for analytics purposes.
Changes
Relays MFRs Request headers to WB.
Side effects
None that I know of.