Update references in file-input SchemaResponseBlocks to match registration_responses post-archival #9804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2021 21:16
mfraezz
approved these changes
Oct 15, 2021
| file_block_ids = self.schema.schema_blocks.filter( | ||
| block_type='file-input' | ||
| ).values_list('id', flat=True) | ||
| if not file_block_ids: |
There was a problem hiding this comment.
Huh. I thought that bool(<empty QuerySet>) used to evaluate to True, which caused some API bugs in the past, but looks like that's not the case anymore.
In [1]: pppids = PreprintProvider.objects.filter(name=None).values_list('name', flat=True)
In [2]: pppids
Out[2]: <QuerySet []>
In [3]: bool(pppids)
Out[3]: False
Was going to suggest .exists(), but that's unnecessary; it would be slightly more efficient than evaluating the whole query here, but the result should be cached when it's used below, leading to no net improvement.
mfraezz
pushed a commit
that referenced
this pull request
Oct 18, 2021
…ation_responses post-archival (#9804) * Update references in file-input blocks to match registration_responses post-archival Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The last thing archiver does is update file references in
registration_responses, these changes were not being carried over to the initial SchemaResponse. Whoops.Changes
_update_file_referencesfunction toSchemaResponsethat specifically identifies SchemaResponseBlocks forfile-input-blocksand updates them without worrying about stateregistration_responsereferencesQA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket