Skip to content

Push API Validation #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2016
Merged

Push API Validation #473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbc9827
Merge branch 'release/0.12.0' into develop
erinspace Jan 26, 2016
339328d
Merge branch 'hotfix/0.12.1' into develop
erinspace Feb 4, 2016
2905ff0
Check for empty string emails that somehow made it through
erinspace Feb 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scrapi/harvesters/push_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ def get_records(self, start_date, end_date):
yield record

def normalize(self, raw):
return NormalizedDocument(json.loads(raw['doc'])['jsonData'])
document = json.loads(raw['doc'])['jsonData']
# This is a workaround for the push API did not have proper email validation
for contributor in document['contributors']:
if contributor['email'] == '':
del contributor['email']
return NormalizedDocument(document)

@property
def run_at(self):
Expand Down