Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#190 Outdoor comfort tab issue with bootstrap #198

Closed

Conversation

danielh7-cs9
Copy link
Contributor

Hi Federico,
We've fixed this issue and have also made the filter Div float underneath when rending to small screen. See screenshot below.

image

image

@danielh7-cs9
Copy link
Contributor Author

Hi @FedericoTartarini, please let @phuongdoan13 and I know if there are any further changes for this :)

Copy link
Contributor

@FedericoTartarini FedericoTartarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @danielh7-cs9 @phuongdoan13 for the great work, please fix the merging issues by pulling the latest code changes from main in particular make sure that the range slider for the hour goes from 0 to 24 and not from 1 to 24, you should see already this change implemented in the code that is in main

html.Div(
className="container-row full-width three-inputs-container",
dbc.Col(
md=6, sm=12, xs=12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have xs I believe since once the size it is small then the column width will be set to 12 already.

],
),
dbc.Col(
md=6, sm=12, xs=12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment

max=24,
step=1,
value=[1, 24],
marks={1: "1", 24: "24"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the new code but the range should be from 0 to 24 the same is true for the min value which should be 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants