Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea/detail page #40

Closed
wants to merge 4 commits into from
Closed

Conversation

XanderVertegaal
Copy link
Contributor

@XanderVertegaal XanderVertegaal commented Mar 8, 2024

Like #35, on which this PR is based, this PR is not to be merged. It is intended as a quick-and-dirty conversation starter for our next team meeting. None of the code used here is written with maintainability/longevity/scalability in mind.

This PR features three views that exemplify how the end user would be able to browse the Lettercraft data and trace the data back to the sources. Visit http://localhost:4200/browse to inspect them.

The first page is an overview of available entity types. Only agents is clickable at the moment.

image

Second, there is a list of agents. This table currently holds only 2 agents, but this could be a massive, paginated table, with various sorting and search functionality. The number in gray marks how many sources corroborate this data point.

image

Lastly, Radegund's detail page shows you the stored information from the sources and allows you to select/deselect these.

image

@lukavdplas
Copy link
Contributor

Neat!

No suggestions for changes, let's show this at the next meeting.

Some thoughts:

  • I would focus on the "agent detail" view, which is the most relevant to us right now.
  • Re. the "browse" page: it's useful if the frontend has an "index" view where you can just see all values, which is similar to what you made here. However, as I understand, the intention is that the primary interface will be more a "guided tour" rather than a table of values.
  • For the source references in the detail view, maybe a numbered reference ([1], [2], etc.) rather than the full title would be cleaner? Repeating the title/author creates a lot of visual clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants