Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing polygons #44

Closed
Construkted-Reality opened this issue Oct 21, 2018 · 9 comments
Closed

Missing polygons #44

Construkted-Reality opened this issue Oct 21, 2018 · 9 comments

Comments

@Construkted-Reality
Copy link

I've created an asset in Cesium Ion, however upon close inspection (when you get up close to the model) there's many missing polygons.
http://construkted.com/cesium/FF_Statue_test-01/
If you get close to any of the statues in this model, you can see a good percentage of polygons missing.
The model is a 9 million polygon model.

How can I fix this?

@hpinkos
Copy link

hpinkos commented Oct 22, 2018

@outsider787 is this what you're talking about?

image

Were these triangles in the source model? Are you able to share the source model with us for testing?
Thanks!

@Construkted-Reality
Copy link
Author

Hi,
The source model doesn't have any holes or missing triangles.
I've done a bunch of tests with various mesh sizes and decimated to various levels by different programs, I keep getting similar results. Missing polygons in the model.

The latest model I uploaded to Cesium Ion is assetId 8281. It's only a 1.4 million poly mesh, and exhibits the same behavior on the statues.
You can download the source model here: http://aonsen.homeip.net:8888/cesium/

@hpinkos
Copy link

hpinkos commented Oct 23, 2018

Thanks for the info @outsider787! One of our developers is working on fixing the problem, and we'll give you an update once the fix is live on cesium.com

@Construkted-Reality
Copy link
Author

What is the problem? Does it have to do with really small triangles?
I don't see the problem happening in areas where the triangles are larger. Just where they are really small.

@hpinkos
Copy link

hpinkos commented Oct 23, 2018

@outsider787 yes, I believe we had a check in our tiler that was incorrectly throwing out small triangles.

@likangning93
Copy link

@outsider787 a little more insight here, we ran into a lot of user data that had zero-area triangles, so we built the ability to automatically remove zero-area triangles into our tiler. The implementation had a bug that we found thanks to this issue, so thanks for your help!

@Construkted-Reality
Copy link
Author

Glad I could help :)

Has a fix been implemented on the live site?

@hpinkos
Copy link

hpinkos commented Oct 24, 2018

@outsider787 not quite yet, the fix is under review right now. Once it is deployed we'll let you know and we'll close this issue.

@lilleyse
Copy link

Hi @outsider787, the fix is now deployed. I tested out your model and it looks great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants