Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all elements in JSON array of double/floats are double/floats before parsing #437

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

joseph-kaile
Copy link
Collaborator

Fixes parsing the 3D Tiles with no texture from here.

@kring
Copy link
Member

kring commented Feb 7, 2022

Good catch @joseph-kaile! I think anywhere that section of code sets any of the isX flags to anything other than false, it should be &= rather than =. So I see at least two more places it should be changed. Also, please update CHANGES.md.

@kring kring merged commit 14bc4d5 into main Feb 10, 2022
@kring kring deleted the fix-parse-json-batch-table branch February 10, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants