Apply transform to "region" bounding volume type #6755

lilleyse · 2018-06-29T02:04:07Z

Before / after

As noted in the Sandcastle comments, this will break tilesets that expect the geometry to be transformed but not the region. We have one test tileset that does this, but I don't think I've ever seen this is practice.

~~This will also require changes to the 3D Tiles spec - this section disallows the transform from being applied to regions.~~

To do:

~~Spec update - Remove tile transform restriction on regions 3d-tiles#326~~
Test
CHANGES.md

cesium-concierge · 2018-06-29T02:04:08Z

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

lilleyse · 2018-07-08T20:54:56Z

Updated. @ggetz can you review?

Modified an existing test to check that a tileset with region bounding volumes can move and still be rendered correctly.

ggetz

Tests are failing with RTC_CENTER tilesets now, are we applying the transforms in the correct order there?

ggetz · 2018-07-10T15:19:42Z

Source/Scene/Cesium3DTile.js

+    function createRegion(region, transform, initialTransform, result) {
+        if (!Matrix4.equalsEpsilon(transform, initialTransform, CesiumMath.EPSILON8)) {
+            return createBoxFromTransformedRegion(region, transform, initialTransform, result);
+        }

        if (defined(result)) {
            // Don't update regions when the transform changes


Is this still needed?

ggetz · 2018-07-10T15:23:20Z

Source/Scene/Cesium3DTile.js

-        var rectangleRegion = Rectangle.unpack(region, 0, scratchRectangle);
+    function createBoxFromTransformedRegion(region, transform, initialTransform, result) {
+        var rectangle = Rectangle.unpack(region, 0, scratchRectangle);
+        var minimumHeight = region[4];


Since we just created an instance of a Rectangle, I think it would be more readable to use east, north, etc class members rather than the accessor. Here and in createRegion.

The reason for the region[4] and region[5] is Rectangle doesn't contain min/max height properties.

lilleyse · 2018-07-11T01:42:49Z

Tests are failing with RTC_CENTER tilesets now, are we applying the transforms in the correct order there?

Ah sorry for not catching that earlier. It was a small change in the test. The tile was out of view and never updated its computedTransform. It worked before because it was considered in view, only because the region didn't get transformed.

lilleyse · 2018-07-11T01:43:25Z

Thanks for the review @ggetz! Should be ready now.

ggetz · 2018-07-11T13:33:46Z

Thanks @lilleyse!

liujingjie · 2018-09-27T09:15:16Z

I modified the '3D Tiles Adjust Height.html' in the Apps/Sandcastle/gallery, i want to rotate the 3D Tiles,the code works in 1.47 but in 1.48 and 1.49 the 3D Tiles disappear when i rotate the 3D Tiles. Is this related to the change?

the code is

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no">
    <meta name="description" content="Adjust the height of a 3D Tiles tileset.">
    <meta name="cesium-sandcastle-labels" content="3D Tiles">
    <title>Cesium Demo</title>
    <script type="text/javascript" src="../Sandcastle-header.js"></script>
    <script type="text/javascript" src="../../../ThirdParty/requirejs-2.1.20/require.js"></script>
    <script type="text/javascript">
        if(typeof require === "function") {
            require.config({
                baseUrl : '../../../Source',
                waitSeconds : 120
            });
        }
    </script>
</head>
<body class="sandcastle-loading" data-sandcastle-bucket="bucket-requirejs.html">
<style>
    @import url(../templates/bucket.css);
    #toolbar {
        background: rgba(42, 42, 42, 0.8);
        padding: 4px;
        border-radius: 4px;
    }
    #toolbar input {
        vertical-align: middle;
        padding-top: 2px;
        padding-bottom: 2px;
    }
</style>
<div id="cesiumContainer" class="fullSize"></div>
<div id="loadingOverlay"><h1>Loading...</h1></div>
<div id="toolbar">
    <div>Height-offset</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: height, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: height">

<div>RotateX</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateX, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateX">

<div>RotateY</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateY, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateY">

<div>RotateZ</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateZ, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateZ">
</div>
<script id="cesium_sandcastle_script">
function startup(Cesium) {
    'use strict';
//Sandcastle_Begin
var viewer = new Cesium.Viewer('cesiumContainer', {
    shadows : true
});

viewer.scene.globe.depthTestAgainstTerrain = true;

var viewModel = {
    height: 0,
    RotateX:0,
    RotateY:0,
    RotateZ:0
};

Cesium.knockout.track(viewModel);

var toolbar = document.getElementById('toolbar');
Cesium.knockout.applyBindings(viewModel, toolbar);

var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
    url : '../../../Specs/Data/Cesium3DTiles/Tilesets/Tileset/tileset.json',
    modelMatrix:Cesium.Matrix4.IDENTITY
}));

tileset.readyPromise.then(function() {
    var boundingSphere = tileset.boundingSphere;
    viewer.camera.viewBoundingSphere(boundingSphere, new Cesium.HeadingPitchRange(0.0, -0.5, boundingSphere.radius * 2));
    viewer.camera.lookAtTransform(Cesium.Matrix4.IDENTITY);
}).otherwise(function(error) {
    throw(error);
});

Cesium.knockout.getObservable(viewModel, 'height').subscribe(function(height) {
    height = Number(height);
    if (isNaN(height)) {
        return;
    }
    var m = tileset.modelMatrix;
    var translation=Cesium.Cartesian3.fromArray([0, 0, height]);

    Cesium.Matrix4.multiplyByTranslation(m,translation,m);
    tileset.modelMatrix = m;
});


Cesium.knockout.getObservable(viewModel, 'RotateX').subscribe(function(RotateX) {
    RotateX = Number(RotateX);
    if (isNaN(RotateX)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationX(Cesium.Math.toRadians(RotateX));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});

Cesium.knockout.getObservable(viewModel, 'RotateY').subscribe(function(RotateY) {
    RotateY = Number(RotateY);
    if (isNaN(RotateY)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationY(Cesium.Math.toRadians(RotateY));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});

Cesium.knockout.getObservable(viewModel, 'RotateZ').subscribe(function(RotateZ) {
    RotateZ = Number(RotateZ);
    if (isNaN(RotateZ)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationZ(Cesium.Math.toRadians(RotateZ));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});//Sandcastle_End
    Sandcastle.finishedLoading();
}
if (typeof Cesium !== "undefined") {
    startup(Cesium);
} else if (typeof require === "function") {
    require(["Cesium"], startup);
}
</script>
</body>
</html>

lilleyse · 2018-09-27T15:28:53Z

Hey @liujingjie, it wasn't this change that caused the problem.

But the tileset in ../../../Specs/Data/Cesium3DTiles/Tilesets/Tileset/tileset.json did change in 1.48 and uses a different method of positioning the tileset (RTC_CENTER rather than CESIUM_RTC) which internally applies matrices in a different order. It might be possible to preserve the original ordering and I'll open an issue for that.

lilleyse · 2018-09-27T15:48:10Z

Looking at this closer the difference in matrix order is intentional. RTC_CENTER it is expected to apply the translation before the model matrix. What ends up happening is the rotation acts on the tileset as if its origin is at the Earth's center, so any small change to rotation will throw it off the screen.

https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/master/specification#order-of-transformations

CESIUM_RTC applies the translation last, which is better for this example, but can still produce incorrect behavior - notice that the child tiles are not aligned on the same plane.

In general it is much easier to transform a tileset if it uses a tile transform on the root tile rather than CESIUM_RTC or RTC_CENTER, which aren't easily movable.

wer200897 · 2018-09-28T10:04:22Z

Looking at this closer the difference in matrix order is intentional. RTC_CENTER it is expected to apply the translation before the model matrix. What ends up happening is the rotation acts on the tileset as if its origin is at the Earth's center, so any small change to rotation will throw it off the screen.

https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/master/specification#order-of-transformations

CESIUM_RTC applies the translation last, which is better for this example, but can still produce incorrect behavior - notice that the child tiles are not aligned on the same plane.

In general it is much easier to transform a tileset if it uses a tile transform on the root tile rather than CESIUM_RTC or RTC_CENTER, which aren't easily movable.

I also encountered the same problem. Versions prior to 1.47 can be used, and later versions, 3dtiles model rotation and resizing will not work.

I use Google translate, because I cannot understand English. The explanation is too complicated (Sorry). Is there any chance you can provide the correct code, or point out which part of the code is wrong? Thanks a lot!

lilleyse · 2018-09-28T14:30:59Z

Ok.. it looks like this PR did break the previous behavior, though I think the previous behavior was working accidentally.

The quick workaround is in Cesium3DTile to change:

center = Matrix4.multiplyByPoint(transform, center, center);

to

center = Cartesian3.add(Matrix4.getTranslation(transform, scratchCenter), center, center);

This fixes the example tileset in 1.47 and any other tilesets that use CESIUM_RTC. But it will break behavior for tilesets using RTC_CENTER, usually newer tilesets, which is why I'm hesitant to open a PR just yet. I think it may be possible to support both though.

wer200897 · 2018-09-29T01:12:14Z

thanks so much! i will give it a try

binfenshijie · 2018-10-19T01:51:57Z

thanks so much! i will give it a try

哥们，搞定了吗，这个问题，向您请教下

binfenshijie · 2018-10-19T01:56:22Z

I modified the '3D Tiles Adjust Height.html' in the Apps/Sandcastle/gallery, i want to rotate the 3D Tiles,the code works in 1.47 but in 1.48 and 1.49 the 3D Tiles disappear when i rotate the 3D Tiles. Is this related to the change?

the code is

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no">
    <meta name="description" content="Adjust the height of a 3D Tiles tileset.">
    <meta name="cesium-sandcastle-labels" content="3D Tiles">
    <title>Cesium Demo</title>
    <script type="text/javascript" src="../Sandcastle-header.js"></script>
    <script type="text/javascript" src="../../../ThirdParty/requirejs-2.1.20/require.js"></script>
    <script type="text/javascript">
        if(typeof require === "function") {
            require.config({
                baseUrl : '../../../Source',
                waitSeconds : 120
            });
        }
    </script>
</head>
<body class="sandcastle-loading" data-sandcastle-bucket="bucket-requirejs.html">
<style>
    @import url(../templates/bucket.css);
    #toolbar {
        background: rgba(42, 42, 42, 0.8);
        padding: 4px;
        border-radius: 4px;
    }
    #toolbar input {
        vertical-align: middle;
        padding-top: 2px;
        padding-bottom: 2px;
    }
</style>
<div id="cesiumContainer" class="fullSize"></div>
<div id="loadingOverlay"><h1>Loading...</h1></div>
<div id="toolbar">
    <div>Height-offset</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: height, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: height">

<div>RotateX</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateX, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateX">

<div>RotateY</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateY, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateY">

<div>RotateZ</div>
    <input type="range" min="-100.0" max="100.0" step="1" data-bind="value: RotateZ, valueUpdate: 'input'">
    <input type="text" size="5" data-bind="value: RotateZ">
</div>
<script id="cesium_sandcastle_script">
function startup(Cesium) {
    'use strict';
//Sandcastle_Begin
var viewer = new Cesium.Viewer('cesiumContainer', {
    shadows : true
});

viewer.scene.globe.depthTestAgainstTerrain = true;

var viewModel = {
    height: 0,
    RotateX:0,
    RotateY:0,
    RotateZ:0
};

Cesium.knockout.track(viewModel);

var toolbar = document.getElementById('toolbar');
Cesium.knockout.applyBindings(viewModel, toolbar);

var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
    url : '../../../Specs/Data/Cesium3DTiles/Tilesets/Tileset/tileset.json',
    modelMatrix:Cesium.Matrix4.IDENTITY
}));

tileset.readyPromise.then(function() {
    var boundingSphere = tileset.boundingSphere;
    viewer.camera.viewBoundingSphere(boundingSphere, new Cesium.HeadingPitchRange(0.0, -0.5, boundingSphere.radius * 2));
    viewer.camera.lookAtTransform(Cesium.Matrix4.IDENTITY);
}).otherwise(function(error) {
    throw(error);
});

Cesium.knockout.getObservable(viewModel, 'height').subscribe(function(height) {
    height = Number(height);
    if (isNaN(height)) {
        return;
    }
    var m = tileset.modelMatrix;
    var translation=Cesium.Cartesian3.fromArray([0, 0, height]);

    Cesium.Matrix4.multiplyByTranslation(m,translation,m);
    tileset.modelMatrix = m;
});


Cesium.knockout.getObservable(viewModel, 'RotateX').subscribe(function(RotateX) {
    RotateX = Number(RotateX);
    if (isNaN(RotateX)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationX(Cesium.Math.toRadians(RotateX));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});

Cesium.knockout.getObservable(viewModel, 'RotateY').subscribe(function(RotateY) {
    RotateY = Number(RotateY);
    if (isNaN(RotateY)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationY(Cesium.Math.toRadians(RotateY));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});

Cesium.knockout.getObservable(viewModel, 'RotateZ').subscribe(function(RotateZ) {
    RotateZ = Number(RotateZ);
    if (isNaN(RotateZ)) {
        return;
    }
    var m = tileset.modelMatrix;
    var m1 = Cesium.Matrix3.fromRotationZ(Cesium.Math.toRadians(RotateZ));
    Cesium.Matrix4.multiplyByMatrix3(m,m1,m);
    tileset.modelMatrix = m;
});//Sandcastle_End
    Sandcastle.finishedLoading();
}
if (typeof Cesium !== "undefined") {
    startup(Cesium);
} else if (typeof require === "function") {
    require(["Cesium"], startup);
}
</script>
</body>
</html>

哥们，问题解决了吗

Able to apply a transform to region bounding volumes

957b228

lilleyse mentioned this pull request Jun 29, 2018

3D tiles bounding volumes don't move with tileset modelMatrix #5984

Closed

Reorder

28b1c4b

lilleyse mentioned this pull request Jul 8, 2018

Remove tile transform restriction on regions CesiumGS/3d-tiles#326

Closed

Apply transform diff rather than full transform

f717788

lilleyse force-pushed the transform-region branch from 4ef4991 to f717788 Compare July 8, 2018 20:48

lilleyse added 2 commits July 8, 2018 16:50

Merge branch 'master' into transform-region

2946a26

Updated CHANGES.md

6a088ea

ggetz self-assigned this Jul 9, 2018

ggetz requested changes Jul 10, 2018

View reviewed changes

Fix test and updates

6872b2d

ggetz approved these changes Jul 11, 2018

View reviewed changes

ggetz merged commit 122d3e7 into master Jul 11, 2018

ggetz deleted the transform-region branch July 11, 2018 13:33

lilleyse mentioned this pull request Sep 27, 2018

Model matrix not getting applied to tileset correctly #7036

Open

lilleyse mentioned this pull request Oct 18, 2018

"3dtile model adjust angle for tileset" how to do it #7166

Closed

lilleyse mentioned this pull request Aug 21, 2019

cesium1.5.0~1.6 can not rotate the model #8095

Closed

OmarShehata mentioned this pull request Feb 13, 2020

rotate 3dtile doesn't work in cesiumjs 1.66 #8611

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply transform to "region" bounding volume type #6755

Apply transform to "region" bounding volume type #6755

lilleyse commented Jun 29, 2018 •

edited

cesium-concierge commented Jun 29, 2018

lilleyse commented Jul 8, 2018

ggetz left a comment

ggetz Jul 10, 2018

ggetz Jul 10, 2018

lilleyse Jul 11, 2018

lilleyse commented Jul 11, 2018

lilleyse commented Jul 11, 2018

ggetz commented Jul 11, 2018

liujingjie commented Sep 27, 2018 •

edited

lilleyse commented Sep 27, 2018

lilleyse commented Sep 27, 2018

wer200897 commented Sep 28, 2018

lilleyse commented Sep 28, 2018

wer200897 commented Sep 29, 2018

binfenshijie commented Oct 19, 2018

binfenshijie commented Oct 19, 2018

Apply transform to "region" bounding volume type #6755

Apply transform to "region" bounding volume type #6755

Conversation

lilleyse commented Jun 29, 2018 • edited

cesium-concierge commented Jun 29, 2018

lilleyse commented Jul 8, 2018

ggetz left a comment

Choose a reason for hiding this comment

ggetz Jul 10, 2018

Choose a reason for hiding this comment

ggetz Jul 10, 2018

Choose a reason for hiding this comment

lilleyse Jul 11, 2018

Choose a reason for hiding this comment

lilleyse commented Jul 11, 2018

lilleyse commented Jul 11, 2018

ggetz commented Jul 11, 2018

liujingjie commented Sep 27, 2018 • edited

lilleyse commented Sep 27, 2018

lilleyse commented Sep 27, 2018

wer200897 commented Sep 28, 2018

lilleyse commented Sep 28, 2018

wer200897 commented Sep 29, 2018

binfenshijie commented Oct 19, 2018

binfenshijie commented Oct 19, 2018

lilleyse commented Jun 29, 2018 •

edited

liujingjie commented Sep 27, 2018 •

edited