From 0214cd783a592ffaf4510255dbd76a3eadb06103 Mon Sep 17 00:00:00 2001 From: Kangning Li Date: Wed, 26 Apr 2017 10:54:11 -0400 Subject: [PATCH 1/2] bugfix for processModelMaterialsCommon --- lib/processModelMaterialsCommon.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/processModelMaterialsCommon.js b/lib/processModelMaterialsCommon.js index 8bc3c72d..58141cee 100644 --- a/lib/processModelMaterialsCommon.js +++ b/lib/processModelMaterialsCommon.js @@ -586,8 +586,8 @@ function generateTechnique(gltf, khrMaterialsCommon, lightParameters, optimizeFo WebGLConstants.DEPTH_TEST, WebGLConstants.BLEND ], - depthMask: false, functions: { + depthMask : [false], blendEquationSeparate: [ WebGLConstants.FUNC_ADD, WebGLConstants.FUNC_ADD From a50a00566d5d4e4a0fe4dee652e52daf7194a6ef Mon Sep 17 00:00:00 2001 From: Kangning Li Date: Wed, 26 Apr 2017 11:01:40 -0400 Subject: [PATCH 2/2] updated CHANGES.md --- CHANGES.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 970a2047..81875729 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,6 +1,9 @@ Change Log ========== +### 0.1.0-alpha13 - ?? +* Fixed a bug in `processModelMaterialsCommon` that produced out-of-spec technique states. + ### 0.1.0-alpha12 - 2017-04-13 * Fixed issue with ambient occlusion not working correctly with other stages. [#267](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/267) * Fixed handling of binary glTF with special characters. [#253](https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/253)