Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deposit to match executeDeposit #115

Merged
merged 2 commits into from May 1, 2020
Merged

Update deposit to match executeDeposit #115

merged 2 commits into from May 1, 2020

Conversation

spacesailor24
Copy link
Contributor

Changes

  • Update deposit method to use stored function signature for external call like executeDeposit
  • Remove old comments

Closes: #114

@spacesailor24 spacesailor24 self-assigned this Apr 30, 2020
@spacesailor24 spacesailor24 merged commit 06dd995 into master May 1, 2020
@spacesailor24 spacesailor24 deleted the wyatt/iss-114 branch May 1, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansermino ansermino ansermino approved these changes

@steviezhang steviezhang steviezhang approved these changes

@GregTheGreek GregTheGreek Awaiting requested review from GregTheGreek

Assignees

@spacesailor24 spacesailor24

Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deposit and ExecuteDeposit in the GenericHandler Make External Call Differently
3 participants
@spacesailor24 @ansermino @steviezhang