Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in dot/rpc tests #1958

Open
kishansagathiya opened this issue Nov 2, 2021 · 0 comments
Open

Improvements in dot/rpc tests #1958

kishansagathiya opened this issue Nov 2, 2021 · 0 comments

Comments

@kishansagathiya
Copy link
Contributor

Issue summary

I think there is an opportunity to improve some of the tests in dot/rpc

  • TestWSConn_HandleComm is one test that contains a lot of tests. It could be structured better by using the testcases-and-for-loop pattern or by using sub-tests. (in /dot/rpc/subscription/websocket_test.go)
  • Test more cases in dot/rpc/websocket_test.go. For some calls, only error cases are tested.
  • We need tests for subscription based calls.

Other information and links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kishansagathiya @P1sar