-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable signature verification in initial sync #1217
Comments
@tuyennhv Would you mind assessing the viability of this now that we have BLST? |
I have some statistics when I sync mainnet until block 28000:
so I think we have to wait for #1771 first where we send a block range to do state transition and verify multiple signatures at the same time. We'll see which signatures we want to verify at that time. |
With batch signature verification we can achieve 50% savings in the best case scenario so it won't help much if are still an order of magnitude away. |
Would be very valuable to know how much time is currently spent doing signature verification. Then we know if we have to focus on optimizing the state transition function itself or signature verification |
as I said above, for initial sync we don't do any signature verification for now so if we do, the time to sync is much bigger. if we plan on having signature verification for initial sync, we need to work on #1771 first before we bench mark. |
Sorry just closed the issue, BLST is already integrated in current master |
@tuyennhv As I summarized in #1771
So the most impactful speed increase is already delivered. That's why I think it's a good time to benchmark how good or bad are we right now. |
thanks for the clarification @dapplion , we haven't applied signature verification for initial sync yet so there's no difference when BLST is in. |
The below statistic is from Pyrmont syncs till slot 5000 in my local environment and latest master
not sure why verifying block signature takes less time although I run twice but at least it's comparable to no signature verification. |
@tuyennhv Thanks for benchmarking this! @wemeetagain Do you think it would be valuable to profile a couple of blocks and check what's the actual time spent in BLS signature verification on a small sample? |
Yes, I think that would be good to more deeply understand these results. I personally don't understand how "block signature verification" could possibly be faster than "no block signature verification". |
Fixed with #2147 |
pending answer to “In initial sync, do we need to verify ALL operations? or just block signature?"
The text was updated successfully, but these errors were encountered: