Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tar archive instead of npm for spec tests #1787

Closed
mpetrunic opened this issue Nov 23, 2020 · 0 comments · Fixed by #1783
Closed

Use tar archive instead of npm for spec tests #1787

mpetrunic opened this issue Nov 23, 2020 · 0 comments · Fixed by #1783
Assignees

Comments

@mpetrunic
Copy link
Member

Problem:
We used npm to distribute spec tests, but spec tests reached size limit of npm registry.

Solution:
Extend lodestar-spec-test-util to download spec tests archive from https://github.com/ethereum/eth2.0-spec-tests/releases/download/v1.0.0/general.tar.gz and resolve file path relative to extracted spec tests.

Method that should be extended:
https://github.com/ChainSafe/lodestar/blob/master/packages/lodestar-spec-test-util/src/single.ts#L61

My suggestion is to add spec tests version as required param and extraction location as optional (defaulting to node_modules/.cache/@chainsafe/lodestar-spec-test-utils).
Upon executing describeDirectorySpecTest, we should check whether directory <spec_tests_location>/ directory exists.
If it does resolve spec test path against it.
If it doesn't, download tar archives for given version extract them all into <spec_tests_location>/ location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants