Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec test utils typescript #379

Merged
merged 23 commits into from Aug 13, 2019

Conversation

@mpetrunic
Copy link
Member

commented Aug 7, 2019

I've decided to update incrementally to avoid huge PR so this is first one moving to typescript with some improvment regarding test names.

  • move to typescript
  • better types
  • improved type generation in build

resolves #358
resolves #293
resolves #357

mpetrunic added 8 commits Aug 4, 2019
Merge remote-tracking branch 'origin/master' into mpetrunic/spec-test…
…-utils-ts

# Conflicts:
#	.eslintrc
#	yarn.lock

@mpetrunic mpetrunic requested review from wemeetagain and GregTheGreek Aug 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 7, 2019

Codecov Report

Merging #379 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #379     +/-   ##
=========================================
+ Coverage   75.95%   76.06%   +0.1%     
=========================================
  Files         198      191      -7     
  Lines        3847     3768     -79     
  Branches      356      355      -1     
=========================================
- Hits         2922     2866     -56     
+ Misses        820      798     -22     
+ Partials      105      104      -1
mpetrunic added 3 commits Aug 7, 2019
Merge remote-tracking branch 'origin/master' into mpetrunic/spec-test…
…-utils-ts

# Conflicts:
#	package.json
#	packages/eth2.0-ssz-types/test/unit/consistency.test.ts
packages/eth2.0-spec-test-util/package.json Outdated Show resolved Hide resolved
packages/eth2.0-spec-test-util/src/bulk.ts Outdated Show resolved Hide resolved
packages/eth2.0-spec-test-util/src/bulk.ts Outdated Show resolved Hide resolved
packages/ssz/package.json Outdated Show resolved Hide resolved
packages/eth2.0-spec-test-util/src/bulk.ts Outdated Show resolved Hide resolved
mpetrunic added 6 commits Aug 7, 2019
mpetrunic added 2 commits Aug 8, 2019
Merge remote-tracking branch 'origin/master' into mpetrunic/spec-test…
…-utils-ts

# Conflicts:
#	.eslintrc
#	.nycrc.json
#	packages/ssz/package.json
#	yarn.lock

@mpetrunic mpetrunic dismissed stale reviews from GregTheGreek and wemeetagain via 93af78b Aug 8, 2019

mpetrunic added 2 commits Aug 13, 2019
Merge remote-tracking branch 'origin/master' into mpetrunic/spec-test…
…-utils-ts

# Conflicts:
#	packages/lodestar/package.json
#	yarn.lock

@mpetrunic mpetrunic merged commit 802ec46 into master Aug 13, 2019

3 of 5 checks passed

ci/circleci: Build Error Your tests failed on CircleCI
Details
codeclimate 17 issues to fix
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details

@mpetrunic mpetrunic deleted the mpetrunic/spec-test-utils-ts branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.