feat: add blacklisted block check#7498
Merged
wemeetagain merged 8 commits intounstablefrom Mar 13, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7498 +/- ##
============================================
+ Coverage 50.14% 50.15% +0.01%
============================================
Files 603 603
Lines 40454 40475 +21
Branches 2226 2229 +3
============================================
+ Hits 20285 20302 +17
- Misses 20129 20133 +4
Partials 40 40 🚀 New features to boost your workflow:
|
wemeetagain
reviewed
Feb 25, 2025
**Motivation** - Black list the whole chain leading to black listed blocks **Description** - Init chain's black listed blocks from chain options - Populate it if a block's parent root is black listed. Gradually the whole chain will be black listed --------- Co-authored-by: Tuyen Nguyen <twoeths@users.noreply.github.com> Co-authored-by: matthewkeil <me@matthewkeil.com>
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
reviewed
Feb 27, 2025
Contributor
There was a problem hiding this comment.
Is this intended to be merged into unstable or is it only to showcase this feature in holesky-rescue?
If former, I don't really think we should pass the blacklisted blocks from cli arguments but probably read it from a file since it can get lengthy.
There is also an argument brought up by lighthouse guys here about this flag can potentially be abused to censor blocks, so we need to take this into account when making design decisions eg. make it harder to use, limit number of blacklisted blocks, restrict the this feature on mainnet etc.
Member
I don't see how that is possible, the node needs to be restarted to black list a block but at this point the block should already have enough votes to be considered part of the canonical chain and the node that blacklists it would just follow a separate (minority) chain. I can't really think of a scenario here, but maybe I am missing something obvious |
Member
|
As discussed on standup #7524 , if this feature is going ahead, it should be merged to unstable before Friday deadline for v1.28-rc.0 |
nflaig
approved these changes
Mar 6, 2025
Member
@twoeths this is a comment from you on discord, do you feel like we still want this? seems simple to implement but I don't feel strongly about adding this although on second thought it might be helpful to see all black listed parent blocks |
Contributor
I think we should add it considering how easy it is to implement |
wemeetagain
approved these changes
Mar 13, 2025
nflaig
added a commit
that referenced
this pull request
Mar 14, 2025
Follow up on #7498 to improve the blacklisted blocks feature - adds new endpoint `/eth/v1/lodestar/blacklisted_blocks` to return root/slot of blacklisted blocks - updates blacklisted blocks store on chain to use `Map` to also keep track of slot - proper parsing of root hex values passed through CLI flag to make sure those are handled as `string` and not `number` - add unit test to sanity check implementation + various type issue fixed not caught due to previous tsconfig issue
Member
|
🎉 This PR is included in v1.28.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Try to save Holesky. Blacklist ancestor of invalid chain and add blacklist BlockError that can be expanded to a feature flag in the future (or API call to add to the errors array)