fix: use correct subnet when validating gossip attestations#7543
Merged
nflaig merged 3 commits intoholesky-rescuefrom Mar 11, 2025
Merged
fix: use correct subnet when validating gossip attestations#7543nflaig merged 3 commits intoholesky-rescuefrom
nflaig merged 3 commits intoholesky-rescuefrom
Conversation
wemeetagain
approved these changes
Mar 10, 2025
ensi321
reviewed
Mar 11, 2025
| serializedData: param.gossipData.serializedData, | ||
| attSlot: param.gossipData.msgSlot, | ||
| attDataBase64: param.gossipData.indexed, | ||
| subnet: param.topic.subnet, |
Contributor
There was a problem hiding this comment.
I think doing this is not enough.
Because gossipValidatorBatchFn is still hardcoding all params to have the same topic. See
Contributor
|
we should pick this work to |
nflaig
added a commit
that referenced
this pull request
Mar 11, 2025
Fix a bug in gossip validation of electra attestations
Member
Author
|
wemeetagain
pushed a commit
that referenced
this pull request
Mar 13, 2025
Apply same fix from #7543 to unstable branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in gossip validation of electra attestations