feat: improve blacklisted blocks feature - #7580
Merged
Merged
Conversation
nflaig
commented
Mar 14, 2025
| { | ||
| config: state.config, | ||
| db, | ||
| dataDir: ".", |
Member
Author
There was a problem hiding this comment.
unrelated change but required to make type check pass, was missed in #7551 due to misconfigured tsconfig
nflaig
commented
Mar 14, 2025
| "chain.blacklistedBlocks": { | ||
| hidden: true, | ||
| type: "array", | ||
| string: true, |
Member
Author
There was a problem hiding this comment.
this is important as otherwise passing the value like this --chain.blacklistedBlocks 0x123213 would interpret it as a number instead of a string
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7580 +/- ##
============================================
- Coverage 50.21% 50.20% -0.02%
============================================
Files 603 603
Lines 40473 40509 +36
Branches 2244 2239 -5
============================================
+ Hits 20325 20337 +12
- Misses 20108 20132 +24
Partials 40 40 🚀 New features to boost your workflow:
|
nflaig
enabled auto-merge (squash)
March 14, 2025 12:47
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
approved these changes
Mar 14, 2025
Member
|
🎉 This PR is included in v1.28.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #7498 to improve the blacklisted blocks feature
/eth/v1/lodestar/blacklisted_blocksto return root/slot of blacklisted blocksMapto also keep track of slotstringand notnumber