Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool should call psycopg2.connect not psycopg2._connect #2

Closed
mjgp2 opened this issue Dec 21, 2023 · 4 comments
Closed

Pool should call psycopg2.connect not psycopg2._connect #2

mjgp2 opened this issue Dec 21, 2023 · 4 comments

Comments

@mjgp2
Copy link
Contributor

mjgp2 commented Dec 21, 2023

Currently the pool calls the private method psycopg2._connect rather than the public method psycopg2.connect. This breaks tooling such as AWS XRay that wraps the public method.
@Changaco
Copy link
Owner

Feel free to open a pull request.

I don't remember why I chose to call the “private” method. It could have been a micro-optimization, or there might have been a more important reason.

@mjgp2
Copy link
Contributor Author

mjgp2 commented Jan 15, 2024

Opened PR: #3

@mjgp2 mjgp2 closed this as completed Jan 15, 2024
Changaco pushed a commit that referenced this issue Jan 15, 2024
@mjgp2
call public psycopg2.connect method (#3)
5a16029 
closes #2
@mjgp2
Copy link
Contributor Author

mjgp2 commented Jan 15, 2024

Thanks for merging @Changaco ! Any chance you can do a release? :)

@Changaco
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjgp2 @Changaco