Dynamic voting window 🚀#309
Merged
chaosbot merged 7 commits intoChaosthebot:masterfrom May 27, 2017
flibustier:dynamic_voting_window
Merged
Dynamic voting window 🚀#309chaosbot merged 7 commits intoChaosthebot:masterfrom flibustier:dynamic_voting_window
chaosbot merged 7 commits intoChaosthebot:masterfrom
flibustier:dynamic_voting_window
Conversation
… extended voting window)
…into dynamic_voting_window
Collaborator
|
🙆♀️ PR passed with a vote of 11 for and 0 against, with a weighted total of 11.0 and a threshold of 6.2. See merge-commit 23ca855 for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bounces on suggestions made in #275
That is to say :
« There are two scenarios that the voting window is needed to be long; where it is being hotly debated, and where it gets no votes for many hours. »
And what is the value of the "extending_voting_window" ?
The value depends of the time since the creation date of the repo, following this rule :
When the repository is less than 3 days, the extending voting windows is 3 hours
When the repository is more stable and advanced, 16 days or more, it's 9 hours